Repository navigation
feat(browser): point the owner to the window when a sign-in fails - #140
Merged
Merged
Conversation
The window sign-in only showed under the live screen, which goes away once the owner takes control to sign in. Now a line under the help callout and the "in control" bar says to use Sign in in a window when the site won't let them in, and the help card in the chat says the same. The bot's rules and browser_ask_owner tell it to suggest the window when a site refuses to sign in to its browser, and to open the page again afterwards. README and spec 21.11 describe it.
httpsphl
enabled auto-merge
October 3, 2026 21:01
On a busy CI runner chrome://version took over 2 s to load, the read gave up, and the brands went empty again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #139. In real use, some sites only let the owner sign in through Sign in in a window, but the app only mentioned that option under the live screen. That text disappears as soon as the owner takes control to sign in.
App (en, pt-BR, es)
Bot
workspace/files.rs): when a site refuses to sign in to its browser ("this browser may not be secure", a sign-in that fails or loops), the bot asks withbrowser_ask_owner, tells the owner in their language to use the window button, then opens the page again.browser_ask_ownerdescription says the same.Docs
Checks: cargo fmt, clippy, the full test suite and
pnpm checkpass. New test inwindow.test.tsx.Manual check with real Claude Code: ask a bot to open a site that refuses its browser. It should ask for help and mention signing in in a window.