Repository navigation
fix(app): smooth switching in the bot's computer, and a page you can see - #160
Merged
Merged
Conversation
The browser, the terminal and the files share one width and keep the dock at their foot, so the dock switches only what is inside: the new panel's content fades up in place instead of sliding in, and the last frame and commands show at once. The page in the browser now takes the panel's width (800 to 1600 px) instead of a fixed 1280, so it shows near its real size; the desk around it is thinner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things the owner asked after using 0.9.1 + main:
Switching between browser, terminal and files was not fluid
botloft.panel.computer, 600 px to start), so switching never changes the width. Before, files was 416 px: going there popped, coming back slid part of the way.panel-swapped); the dock and the resize handle stay still.The page in the browser was tiny
Test plan
cargo fmt,clippy -D warnings,cargo test --workspace(viewport unit tests,browser_panel.rswith the real Edge for the new sizes)pnpm check(room size, swap class on dock switch)