Repository navigation
test(browser): give real-browser tests time on busy CI runners - #164
Merged
Merged
Conversation
Two flakes on CI: a site request expired after the tests' 3 s approval wait on Ubuntu, and a new tab's address arrived after 5 s on macOS. The browser tests now run on a daemon whose approvals wait 30 s, and the new tab gets 20 s; both checks end as soon as what they wait for comes.
httpsphl
enabled auto-merge
October 4, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two flaky failures of the real-browser tests on CI, unrelated to the PRs they hit:
words_made_of_one_element_per_letter_keep_their_spacesgot "The owner did not answer about 127.0.0.1 in time": the site request expired after the tests' 3 s approval wait while Chromium was slow to ask.new_tabs_and_dialogs_reach_the_bot_and_the_owner_watchessaw the new tab still without its address after 5 s.Changes (tests only):
TestDaemon::start_supervised_patient(): approvals wait 30 s. The browser tests'setup()uses it; tests about expiry keep the 3 s daemon.Test plan
cargo test -p botloftd(the four browser test files locally with Edge)