Skip to content

fix(app): the bot's page fills the desk, and the notes under it fold - #166

Merged
httpsphl merged 1 commit into
mainfrom
fix/browser-fill
Oct 4, 2026
Merged

httpsphl merged 1 commit into
mainfrom
fix/browser-fill

Conversation

@httpsphl

@httpsphl httpsphl commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Why

With the owner in control, the bot's page showed small, with wide bands of the bot's color on both sides.

The cause was a mismatch between how the page was sized and how much room it really had:

  • The page size came from the panel's height minus a fixed 56 px kept for the pill.
  • In control, the notes under the pill took far more height than that: the teach button with its explanation, the click-to-type hint, the task and the window row.
  • The page was taller than its real room, so it shrank to fit by height. The text got small and the desk showed on the sides.

What

  • Page size. The room is now measured where the page shows: the size container inside the desk's edge. The page takes exactly that shape (browser.resize), so it fills the desk at its own size.
    • A notice that comes or goes (the help request, the notes) now resizes the page. Before, it shrank the page instead.
  • Notes under the pill, while in control.
    • The bot's request stays visible, on one line.
    • Below it, one row of buttons: Teach a task, Sign in in a window, How it works.
    • Everything else is folded under How it works: click to type, the bot waits, the bot goes on in the tab you leave, why teach, and the window hint.
  • Lesson steps. While a lesson records, its steps scroll inside a fixed height, so each new step no longer resizes the page.
  • The pill. It still hangs on the desk's bottom edge. It reaches 20 px into the 26 px bottom edge, so it never covers the page.
  • Spec 21.3, 21.7, 21.8, 21.10 and 21.13 are updated.

Checks

  • pnpm check passes. The room test now expects the measured desk room, and the tabs test opens How it works before reading the folded line.
  • In the preview with FakeBotloft, in control: the page is 260×298 inside a 264×298 room, so only the border shows. The pill sits under the page.

Manual check on the real app

Open a bot's browser and take control:

  1. The page fills the desk, with no wide colored bands.
  2. The pill sits under the page.
  3. Teach a task, Sign in in a window and How it works sit in one row.

The page was sized for the panel minus a fixed allowance, but with the
owner in control the notes under the pill took more height than that, so
the page shrank to fit by height and left wide bands of the desk on both
sides. Now the room is measured where the page shows, inside the desk's
edge, so the page fills it at its own size. Under the pill, the owner's
notes are one row of buttons (teach, window, how it works) with the hints
folded, and a lesson's steps scroll in a fixed height, so the page keeps
the room. The pill still hangs on the desk's bottom edge, never over the
page.
@httpsphl
httpsphl enabled auto-merge October 4, 2026 20:17
@httpsphl
httpsphl merged commit 2d737e9 into main Oct 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant