Repository navigation
feat(desktop): outline in the bot's color around the window it uses - #184
Merged
Merged
Conversation
While a bot reads or acts in a window, the daemon draws a thin ring in the bot's color around the window's frame on the owner's screen. It is a click-through, see-through tool window placed right above the app in the order of windows, so a window of the owner's in front covers it too. It follows the window every 250 ms, steps aside while it is minimized, and goes 3 s after the bot's turn ends, after a minute without desktop use, or when the owner stops the bot. A daemon task follows desktop.changed and bot.state to decide; the notice and the outline now share a small overlay facade in the platform module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner asked for the window, or the desktop, to show the bot's color the whole time a bot is using it (spec 24.9).
What changes
platform/desktop/windows/outline.rs:desktop/outline.rs, spawned inmainnext to the browser sweep:desktop.changed(a read, a picture or an action) andbot.state;overlay.rsfacade (notice_*,outline_*). This keepsplatform/desktop/mod.rsunder 300 lines.Tests
Manual