Repository navigation
feat(app): the card to let a bot reach another crew, and the list in its details - #195
Merged
Merged
Conversation
…wner's OK Crews stay closed to each other. When the owner wants it, a bot asks with ask_crew_access: the crew, one bot of it or the whole crew, what it needs (talk) and why. The owner allows it only now (until the bot's turn ends), always for that bot, always for the crew, or declines. With access, crew_roster and send_message take crew; the other side can answer, and tasks come back. Messages and tasks across crews belong to the recipient's crew, so deleting a crew leaves nothing dangling. Spec 9.3, 10, 10.4.
…its details The request card says what the bot wants in the other crew and why, with Only now, Always <bot>, Always the crew and Deny. The answer keeps the request with its scope, so the answered line says for how long. The bot's details list 'Other crews' it reaches for good, each with a button to take it back (crewAccess.list and crewAccess.revoke). Spec 10.4, 11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #194, stacked on it: this diff includes #194's commit until that merges.
ask_crew_access:input: {"scope": ...}. The daemon keeps the request with its scope, so the answered line says for how long.crewAccess.list {botId}andcrewAccess.revoke {accessId}.Spec: 10.4 (the app part) and the methods in 11.
Tests:
crewAccess.test.tsx: the one-bot request, the whole-crew request with a deny note, and the list with revoke.tests/crew_access.rs: list and revoke, and the kept scope.Manual: ask a bot to talk with a bot of another crew. Check the card, the answered line and the details list.