Repository navigation
refactor(agent): Claude behind an Agent trait for launch and input (A1a) - #241
Merged
Merged
Conversation
The process arguments, the extra environment and the encoding of a turn on stdin move from the supervisor and the courier into agent::ClaudeAgent; those two call agent::of(bot.agent). No change for Claude bots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice A1a of spec 30. New
agentmodule: anAgenttrait (args,extra_env,encode_turn),ClaudeAgent, andagent::of(kind)(None for codex/agy until A2/A3).supervisor/spawn.rsbuilds the command line through the agent instead of hard-coding Claude's flags.courier/render.rsbuilds a neutralTurn(text and encoded images) and the agent writes the stdin line.Next: A1b (reading the output as normalized events), A1c (discovery and login, workspace files, approvals).
fmt, clippy -D warnings and
cargo test --workspacepass.