Repository navigation
feat(agents): Codex gets a model list, an effort and images (A3c of spec 30) - #251
Merged
Merged
Conversation
…pec 30) agents.models answers for codex (model/list on a short-lived app-server, cached 10 minutes); the composer shows the effort slider and the model picker for Codex bots; the effort goes in each turn/start. An image goes as a data URL image input. Checked with the real codex: an image was read with effort low.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last slice of the Codex bot (after #249 and #250), the three things it lacked next to the others.
agents.modelsanswers forcodex: a short-livedcodex app-serverrunsmodel/list(hidden models left out, display names), cached 10 minutes per agent. The composer shows the model picker for Codex bots; the model goes in the thread (Bot.agentModel).effortin eachturn/start.imageinputs with a data URL (checked with the real Codex: a red PNG was read as 'Red', with effort low).Not in this PR: the Codex plan usage (
account/rateLimits/updated) belongs to another account than the one the usage screen shows; it comes with per-agent accounts.Tests: wire unit tests (an image becomes a data URL; the model list parse), an app test for the Codex bot's pickers; fmt, clippy -D warnings,
cargo test --workspaceandpnpm checkpass.