Repository navigation
feat(agent): find Codex wherever it was installed, and Brave or Chrome - #258
Merged
Merged
Conversation
A friend's Codex came from mise and his browser was Brave, so the agent sat in "Restarting" and the browser tool found nothing. The search now uses the owner's PATH and the folders of the usual managers (and an npm .cmd leads to its native program); Windows tries Edge, then Chrome, then Brave. Settings can say where an agent's program is (agents.setPath), and an agent that is not found says so in its chat instead of only restarting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A friend testing 0.15 had Codex installed by
miseand used Brave: the agent sat in "Restarting" with no reason, and the browser tool found no browser.PATH, the folders of mise, pnpm, Volta, npm, Scoop, Cargo and Bun (and Homebrew off Windows), and from an npm.cmdreaches the native program in its package. AGY follows the same search.agents.setPath, saved ascodex_path/agy_path, applied at once).Checks:
cargo test --workspace, clippy, fmt,pnpm checkpass; new tests for the search, the config key, the RPC, the Settings row and the chat notice.Manual step: with Codex installed through mise or npm, switch on experimental agents and see it found; with a path pasted in Settings a stuck agent starts. With only Brave installed, a browser tool call opens a page.