Repository navigation
feat(app): a Write line in the chat opens its file in the files panel - #29
Merged
Merged
Conversation
Tool lines that changed a file, and worked, get a Show in files button that opens the panel on that file's preview; a file that is gone says so. Spec 15.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A tool line in the chat that changed a file (`Write`, `Edit`, `MultiEdit`, `NotebookEdit`) and did not fail now has a small Show in files button. It opens the files panel (reading the list first) straight on that file's preview. If the file is no longer there, the panel says so, with a way back to the list. Failed calls and other tools have no button.
The line itself still expands to show input and output; the button is separate, so it is not a button inside a button. The chat reaches the panel through a small context (`ShowFile`), so no props go through `ChatView` and `BotRun`.
Text in English, Portuguese and Spanish. Spec 15.1.
Tested
`pnpm check` (tsc, biome, 115 tests). New tests: the button shows only for a successful file change and opens the preview; a missing file shows the "no longer there" message. Checked by eye in the dev preview.