Repository navigation
test(setup): wait for the window to be shown - #59
Merged
Merged
Conversation
The setup window is shown in an effect, which can run after the test finds the first page. The check failed now and then, locally and in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
setup.test.tsx > installs, then opens the appfailed now and then withexpected [ 'state' ] to include 'show': once on my machine and once in the App (Windows) check of #56 (run 36725378541), on code that does not touch the setup window.The setup window calls
host.show()in an effect, once the first page is drawn. The test looked for the call right after finding the page, and the effect can run after that. It now waits for the call.Tests
src/setup/setup.test.tsxpasses; only the test changed.