Repository navigation
feat(app): an effort slider and the conversation's space below the chat - #64
Merged
Merged
Conversation
Delete is the last action of the bot's menu (header and right-click) and of the crew's menu. The confirmation names the bot or crew and says what goes (the conversation, routines and tasks, for good) and what stays (the folder, with its path). A message from a bot that left, archived or deleted, reads as from a bot no longer in the crew.
The other lists leave archived crews and bots out, so nothing showed them. archive.list returns both, the latest archived first, for the app to list and delete.
Settings gets an Archived part: the crews and the bots the owner archived, which the rest of the app does not show, with the same delete confirmation as the menus. The confirmation is now a component of its own (DeleteBot, DeleteCrew) and says "leaves" instead of "stops now" for what was already stopped.
…or good With the shell's IFileOperation on a thread of its own (it needs a single-threaded apartment). A progress sink aborts any item the shell would destroy instead of recycling, so what the bin cannot take stays where it is. The tests use the real Recycle Bin, check the folder is in it and take it out again.
…n when asked bots.delete and crews.delete take recycleFolder. The method answers at once; the folder moves afterwards, off the server's workers, tried again while the process that was just killed still holds its files, and folder.recycled tells the apps how it ended. Only a folder under the workspaces goes, and never one that holds a work folder the owner chose.
… Recycle Bin Unchecked by default: the folder stays. Checked, the confirmation says the folder goes to the Recycle Bin, where it can still be got back, and a notice tells the owner if it could not go.
The bin records the long path, and the temporary folder of the CI runner comes in the short one (RUNNER~1), so the tests did not find the folder they had just moved.
Claude Code's Bash and PowerShell tools take an optional `description` next to `command`, written by the model, and it reaches the permission tool unchanged (checked with 2.1.284, spec 19). The daemon now passes it along as `explanation` on the tool and approval chat items, so the app can put plain words before the command. `summary` is the command itself again, as the spec says. The bot writes the explanation, so it never replaces the command: a command's input is kept up to 32 KB instead of 4 KB, for the owner to read all of what they allow, and Claude Code still gets back the input it asked about. The generated rules ask each bot to describe every command for an owner who may not be technical, in the language the owner writes in. Without the rule the text was terse and, on Sonnet, in English. The field stays optional: real Sonnet bots were seen leaving it out.
The card for a request to run a command used to show the raw command, which an owner who does not read commands allowed without knowing what it did. It now shows what the bot says the command is for as its main text, says the bot wrote it and that what runs is the command, and keeps the whole command behind "See the command". With no explanation the card says so and opens the command. The tool line above the card shows the same words, and opens to the command itself instead of its JSON. Other tools keep their summary, with the input under "Details". The preview's seed has a long heredoc command with an explanation and a plain one without.
…onversation Spec 7.4, 8.6, 9.2, 11.2, 11.3, 12 and the findings in section 19. bots.setEffort restarts the bot with --effort when nothing is in progress; the daemon asks Claude Code what the session applies and how full the conversation is (control requests on stdin), follows each model request, and bots.compact writes /compact. The fake daemon of the app knows the new fields and methods; the UI comes next.
Spec 15.1. Next to the model, a slider from faster to smarter sets the bot's effort, with the level its model uses by itself marked as the recommended one; a model without levels says so. A ring shows how full the conversation is, how far it is from compacting by itself, and compacts it now. Compactions read as notices in the owner's language. In a narrow chat the controls on the right move to their own line.
Brings in main (#52, #53, #54, #55, #59, #62, #67) and feat/delete-recycle (#56, #58, #60), so this PR merges in any order with them. - app/src/lib/fakeBots.ts, crates/botloftd/src/state.rs, docs/spec.md: both sides kept (bot.context next to bot.deleted, crew.deleted and folder.recycled; the context store next to the trash). - crates/botloftd/src/supervisor/spawn.rs: both sides kept, without recording the session at launch (#67 records it from the first turn). - tests/bot_effort.rs and tests/compaction.rs: the bot has a turn before its conversation is resumed, as #67 described.
…mmand-explanation Brings in feat/bot-effort-context (#63) with main and the delete stack, so this PR merges in any order with them. - crates/botloft-core/src/chat.rs: a command's line in the list shows the bot's explanation, and a compaction notice still leaves the list alone. - docs/spec.md: both sides kept (settings.json and rules\botloft.md in the bot's folder, the fields of Bot, the date of the section 19 check). - crates/botloft-store/src/delete/tests.rs: the approval item the delete tests build has the new explanation field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app half of effort and context per bot, on top of #63 (merge #63 first, with a merge commit; until then this PR also shows its commit).
What the owner sees
Below the chat, between the keys hint and the model:
Details
default, so the bot keeps following its model's own level after a model change.bot.context.FakeBotloftleaves compaction notices out of the conversation-list line, like the daemon.Tests
pnpm checkpasses (203 tests). New:effort.test.tsxandcontext.test.tsx, onFakeBotloft.Seen in the browser preview (dark and light, wide and narrow), and with
?liveagainst a dev daemon running the real Claude Code 2.1.284:--model sonnetwith no--effort.Still to see
pnpm tauri dev): the slider's look uses::-webkit-slider-thumb, which the preview's Chromium and WebView2 share, but it was only seen in the preview.