Repository navigation
ci: the daemon on Ubuntu and macOS - #94
Merged
Merged
Conversation
embed-resource is a build dependency on Windows hosts only, so build.rs must not name it elsewhere.
- With no scheduled task off Windows, finding one answers 'not installed' instead of failing, so saving the settings works. - The owner name falls back to LOGNAME and the home folder name. - file: URLs keep the leading slash of POSIX paths, so bots can open pages from their folders.
- The config test's TOML literal had one backslash too many; Windows paths hid it by merging the separators. - The installed binary has no .exe off Windows, so the expected names are sorted like the listing. - Archiving a queued message holds the bot's start, so a fast start can no longer take the message first.
First slice of Linux/macOS support (spec 18, item 8). The Ubuntu job covered only core and store; it now runs clippy and the tests of the default members, with macOS alongside. The app crates join when the app runs there.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of Linux/macOS support (spec 18, item 8): the daemon builds and passes its tests on Ubuntu and macOS, checked on every PR.
Changes
botloft-coreandbotloft-store, becomesRust (Ubuntu)andRust (macOS): clippy with-D warningsand the tests of the default members (core, store, daemon). The app crates join when the app runs there.build.rsnamedembed_resource, a build dependency on Windows hosts only, so the daemon did not compile on Linux or macOS.LOGNAMEand then the home folder name.file:URLs keep the leading slash of POSIX paths, so bots can open pages from their folders..exesorts last.Checks
rust:latest):cargo clippy --all-targets -D warningsandcargo test, all green.Branch protection
The required check
Rust core + store (Ubuntu)no longer exists. Once this PR is green, it is replaced byRust (Ubuntu)andRust (macOS).No real Claude Code involved.