Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1441.
F1_scoreconverted answers to sets, so repeated words disappeared before scoring. For example, referencered blueand predictionred red red bluereceived 1.0 instead of 2/3.Count matching token occurrences with
Counterand use the original token lengths for precision and recall. Normalization and aggregation over references/predictions stay in place. Empty answers retain their current behavior; this does not address #1354.The new tests cover repeated tokens on either side, normalization, multiple references/predictions, and unchanged exact-match, disjoint and empty cases. Five regression cases fail on main and pass with this change.
Tests: base metrics, normalization tests and the existing
f1_score.jsonfixture: 24 passed, 1 skipped, 2 deselected. The skip is the existing pass-at-k placeholder; the two deselected dynamic metric tests require the optional multilingual extra, which is not installed locally. Repository-widemake qualityand changed-file pre-commit checks pass. No full benchmark run was performed.Codex assisted with the fix, regression tests and review.