T8: Wizard join phase (runWizardJoin) wrapping the login lane#372
Merged
philcunliffe merged 1 commit intoJul 22, 2026
Conversation
Add `src/core/cli/wizard/join.js` with `runWizardJoin(opts)`, a thin narration wrapper around the existing `runRemoteLogin` (@ref LLP 0134 #login-lane) - never a second enrollment mechanism. It runs the login lane, waits (bounded) for the daemon to converge on the org config, and computes `lockedSources` as the picker source ids the central layer owns (T2's `pickerDescriptors`, T3's `classifyClientProvenance`). On timeout or the no-org-config 404 steady state it narrates and returns an empty lock set rather than blocking (@ref LLP 0129#join-before-picker). - Export `waitForCentralConverge` from `remote_commands.js`, reusing the bounded reconcile-wait (`waitForClientAttach`) `runRemoteLogin` already performs internally instead of a second poll loop. - Add `classifyLoginFailure`, mapping the login lane's D7 taxonomy (`no_membership` / `org_not_permitted` -> definitive, vs transient) to `'failed' | 'abandoned'`; the two definitive D7 phrases are lifted to exported constants so the classifier reuses the taxonomy rather than re-encoding it. - Tests cover the converge, timeout, and login-failure branches, the locked-source computation against a fixture layered config, the D7 classification split, and `waitForCentralConverge`'s ok/timeout verdict. Task-Id: T8
philcunliffe
merged commit Jul 22, 2026
ab2627d
into
integration/install-experience-overhaul
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements task T8 of install-experience-overhaul.
Adds
src/core/cli/wizard/join.jswithrunWizardJoin(opts), a thin narration wrapper around the existingrunRemoteLoginlogin lane (never a second enrollment mechanism, @ref LLP 0134#login-lane). It runs the login, waits (bounded) for the daemon to converge on the org config, and computeslockedSourcesas the picker source ids the central layer owns. On a timeout or the no-org-config 404 steady state it narrates and returns an empty lock set rather than blocking (@ref LLP 0129#join-before-picker).waitForCentralConvergefromremote_commands.js, reusing the bounded reconcile-waitrunRemoteLoginalready performs internally (waitForClientAttach), not a second poll loop.classifyLoginFailure, mapping the login lane's D7 taxonomy (no_membership/org_not_permittedvs transient) to'failed' | 'abandoned'.Checks:
npm run typecheckclean; new tests green. The 7 pre-existingleave-commandtest failures are unrelated to this change (they fail identically on the base integration branch).Task-Id: T8