Skip to content

Include limit and bytes received in output_limit_exceeded errors - #125

Open
shrisukhani wants to merge 1 commit into
mainfrom
devin/1790933101-output-limit-details
Open

shrisukhani wants to merge 1 commit into
mainfrom
devin/1790933101-output-limit-details

Conversation

@shrisukhani

@shrisukhani shrisukhani commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

output_limit_exceeded errors now report the configured maxOutputBytes and the number of bytes received. This brings the Node SDK in line with the matching python-sdk change.

Changes

  • Message: Command output exceeds maxOutputBytes (8 bytes received, limit 4); increase the collection limit or disconnect a detached process
  • details now also includes max_output_bytes and received_bytes, next to the existing process_id and last_seq.
  • ProcessOutput.failure() takes an optional details record. The python_reference.json fixtures still pass because they match details as a subset.

Validation

  • npm run lint, npm run typecheck
  • vitest run tests/unit/process-collection.test.ts tests/unit/python-reference.test.ts (254 passed), including a new test for the error message and details

Link to Devin session: https://app.devin.ai/sessions/12e69524b921442f8ad62f908b07df87
Open in Devin Desktop: https://app.devin.ai/desktop/session/12e69524b921442f8ad62f908b07df87?variant=devin
Requested by: @shrisukhani


Note

Low Risk
Only enriches error messaging and metadata for an existing failure path; no change to collection logic or limits.

Overview
output_limit_exceeded errors now tell callers exactly how much output was collected versus the configured cap, matching the Python SDK behavior.

When command output exceeds maxOutputBytes, the error message includes received bytes and the limit, and HyperbrowserError.details adds max_output_bytes and received_bytes alongside the existing process_id and last_seq. ProcessOutput.failure() accepts an optional extra details map that is merged into those error details.

A unit test asserts the new message text and detail fields when exec hits the limit.

Reviewed by Cursor Bugbot for commit 304f916. Bugbot is set up for automated code reviews on this repo. Configure here.

@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant