Skip to content

Include limit and bytes received in output_limit_exceeded errors - #134

Open
shrisukhani wants to merge 1 commit into
mainfrom
devin/1790933099-output-limit-details
Open

shrisukhani wants to merge 1 commit into
mainfrom
devin/1790933099-output-limit-details

Conversation

@shrisukhani

@shrisukhani shrisukhani commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

output_limit_exceeded errors now report the configured max_output_bytes and the number of bytes received. Before this, callers such as Harbor saw a generic message and could not tell how far over the limit a command went.

Changes

  • Message: Command output exceeds max_output_bytes (8 bytes received, limit 4); increase the collection limit or disconnect a detached process
  • details now also includes max_output_bytes and received_bytes, next to the existing process_id and last_seq.
  • ProcessOutput.failure() takes an optional details dict that is merged into the error details.

Validation

  • ruff check and ruff format --check on the changed files
  • pytest tests/test_sandbox_process_collection.py (22 passed), including a new test for the error message and details

Link to Devin session: https://app.devin.ai/sessions/12e69524b921442f8ad62f908b07df87
Open in Devin Desktop: https://app.devin.ai/desktop/session/12e69524b921442f8ad62f908b07df87?variant=devin
Requested by: @shrisukhani


Note

Low Risk
Backward-compatible error enrichment only; no change to collection limits or success paths.

Overview
When sandbox command output hits max_output_bytes, HyperbrowserError now tells callers how far over they went instead of a generic limit message.

ProcessOutput.failure() accepts an optional details map merged with process_id and last_seq. The output_limit_exceeded path sets max_output_bytes and received_bytes in details and embeds those counts in the error string (e.g. “8 bytes received, limit 4”).

A focused test asserts the code, details, and message text when exec exceeds a small byte limit.

Reviewed by Cursor Bugbot for commit efa49e5. Bugbot is set up for automated code reviews on this repo. Configure here.

@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant