Repository navigation
Use managerFilePatterns in the Renovate custom manager - #8
Merged
Merged
Conversation
Renovate renamed the custom-manager fileMatch option to managerFilePatterns, and the dependency dashboard flags the old name as needing migration. managerFilePatterns matches "Makefile" as a glob, so it resolves to the root Makefile, the only one that pins the job executor version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate renamed the custom-manager
fileMatchoption tomanagerFilePatterns. The dependency dashboard (#6) flags the old name under "Config Migration Needed"; this is that migration, done by hand.One detail worth noting for this repo.
managerFilePatternstreats an undelimited string as a glob, soMakefilenow resolves to the rootMakefileonly, whereas the oldfileMatchregex would also have matcheddata-container/Makefile. The rootMakefileis the only one that setsHF_JOB_EXECUTOR_VERSION, so nothing is lost and the scope is now explicit.Validated with
renovate-config-validatorfrom renovate 42.99.0: "Config validated successfully".