Repository navigation
Registry error diagnostics - #133
Merged
Merged
Conversation
Collaborator
Author
|
NOTE: I just remembered that the warning for a document that references schema whose identifier is ambiguous only works for the top level. If the document references a schema that references a schema whose identifier is ambiguous, we should still get the warning. |
The ambiguous identifier warning on $schema only checked the schema it names. A schema it references, directly or indirectly, with a duplicate identifier is just as ambiguous, so those are now reported on $schema too. Dependencies come from the compiled schema, which is shared with validation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #119
Adds a
SchemaRegistrationDiagnosticsProviderthat handles surfacing errors related to registering schemas, especially handling duplicate identifier errors. Duplicate ids now get an error on the schema that wasn't registered, a warning on the schema that was registered, and a warning on any schema that$schemas a schema whose identifier is ambiguous. Cache invalidation and diagnostics work as expected when the error is resolved.Also includes a fix for URI normalization problems on windows.