Skip to content

fix(ci): unbreak workflow YAML and add a complete actions.lock - #11

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking
Aug 27, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at startup_failure — zero jobs, no logs, nothing in REST or GraphQL. Full analysis: hyperpolymath/standards#657.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead → 0 startup_failure, 13 running.

Five steps, in order — each blocks the next

1. Unbreak the workflow YAML. Any permissions: carrying a scalar with an indented mapping under it:

permissions: read-all
  actions: read        # <- mapping under a scalar. Unparseable.

This reaches past the one file: gh actions-lock refuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.

2. Repin standards reusables off commits with no actions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.

3. Generate the lockfile with gh actions-lock.

4. Hand-add the reusable-caller entries the tool omits, as '<path>': [].

⚠️ Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Running gh actions-lock and stopping there is how this outage spread.

5. Restore SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps via head -1.

Verified before this PR was opened

0 unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.

🤖 Generated with Claude Code

Remediates GitHub Workflow Dependency Locking (public preview), which
rejects runs at startup_failure with zero jobs and no logs. See
hyperpolymath/standards#657.

Five steps, in order, because each blocks the next:

1. Unbroke any workflow whose `permissions:` carried a scalar with an
   indented mapping under it - blind-permissions-insertion damage. This
   matters beyond the one file: gh actions-lock refuses to run when ANY
   workflow in the repo fails to parse, so the repo could never acquire a
   lockfile and could never self-heal.

2. Repinned hyperpolymath/standards reusables off commits that have no
   actions.lock. The rejection requires the CALLEE to be covered at the
   pinned SHA, which is unsatisfiable at a pre-lockfile commit.

3. Generated the lockfile with gh actions-lock.

4. Hand-added the reusable-workflow caller entries the tool omits, as
   '<path>': []. Measured across 218 repos: P(startup_failure | has
   lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile
   OMITS is rejected. A PARTIAL lock is worse than none - running
   gh actions-lock and stopping there is how this outage spread.

5. Restored SPDX-License-Identifier to line 1, which the tool displaces
   with its own banner and which the workflow-security linter greps with
   head -1.

Verified before push: 0 unparseable workflows, lockfile covers every
workflow with no omissions, SPDX on line 1 in every file.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0
startup_failure, 13 running.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit 6a09e96 into main Aug 27, 2026
1 check passed
@hyperpolymath
hyperpolymath deleted the fix/workflow-dependency-locking branch August 27, 2026 03:55
@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0063e59b-74cf-402b-a6a9-ee58a2e65b87

📥 Commits

Reviewing files that changed from the base of the PR and between 663d5f4 and 2c0e34c.

⛔ Files ignored due to path filters (1)
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/push-email-notify.yml
  • .github/workflows/secret-scanner.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated automated workflow configuration and management annotations.
    • Updated the email notification action to version 3.12.0.
    • Granted the required workflow permission for secret scanning.
    • No changes to application functionality or user-facing behaviour.

Walkthrough

Two GitHub Actions workflows now include gh actions-lock management comments. The email notification workflow uses dawidd6/action-send-mail@v3.12.0. The secret scanner workflow grants actions: read permission.

Changes

Workflow updates

Layer / File(s) Summary
Workflow configuration updates
.github/workflows/push-email-notify.yml, .github/workflows/secret-scanner.yml
Both workflows include management comments. The email workflow changes the mail action from a pinned commit SHA to v3.12.0. The secret scanner workflow adds actions: read permission.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks the workflow lines

New tags hop where old pins stood
Read permissions join the signs
Managed comments mark the code
The pipelines twitch their ears
And bound through tidy YAML fields


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@gitar-bot

gitar-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR effectively addresses the immediate workflow startup failures by correcting YAML syntax and introducing an actions.lock file. However, Codacy analysis indicates the changes are not currently up to standards.

A critical security finding was identified in .github/workflows/push-email-notify.yml, where a third-party action is pinned to a mutable version tag rather than an immutable commit SHA. This poses a supply chain risk and partially undermines the objective of robust dependency locking. All other acceptance criteria, such as license preservation and mapping syntax for permissions, appear to be met.

Test suggestions

  • Verify 'SPDX-License-Identifier' is preserved on line 1 after tool execution
  • Ensure 'permissions' block in workflows uses valid mapping syntax
  • Confirm all external actions and reusable workflows are pinned to versions or SHAs
  • Verify 'actions.lock' contains entries for all workflows to prevent startup_failure

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

steps:
- name: Send push notification email
uses: dawidd6/action-send-mail@6e502825a508b867ab2954ad6343b68787624c01 # pinned
uses: dawidd6/action-send-mail@v3.12.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Pinning third-party actions to a full commit SHA is a security best practice. While tags like v3.12.0 are convenient, they are mutable and could be changed to point to malicious code. Using a SHA ensures the integrity of the action used in your CI/CD pipeline.

Try running the following prompt in your IDE agent:

Find the commit SHA for dawidd6/action-send-mail version v3.12.0 and update the uses statement in .github/workflows/push-email-notify.yml to use that SHA instead of the tag, while keeping @v3.12.0 as a comment for reference.

See Issue in Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant