Repository navigation
refactor(frontend): remove the Evidence UI, keep the Evidence API (#7) - #220
hyperpolymath wants to merge 1 commit into
Conversation
Issue #7 parked the Evidence surface because its semantics belong to the theory track and its browser implementation is being rewritten for the Vue/Marid client. The backend is complete and tested; the React surface is the part that has to go. Removed from the React frontend: - `frontend/src/evidence/` — claim editor, fibre/echo view, residual explorer, projection controls, `claims.ts`, `figures.ts`, `types.ts`, `ui.tsx`, and `evidence.test.ts` - `components/EvidenceModeToggle.tsx` and the `api.evidence` namespace - the `evidence` tab in `RunView` and its entry in the tab list The toggle also gated the placement CladeCumulus panel, which is exactly what issue #7 complained about: the panel now renders unconditionally in the Trees view instead of appearing only when Evidence Mode was switched on. Kept: `src/core/evidence.jl`, `src/server/routes/evidence.jl`, `test/unit/test_evidence.jl` and `test/unit/test_evidence_routes.jl` — the claim schema, residuals, verdicts and SQL are unchanged and still covered. The README section now documents the API and its validation rules rather than three UI views, so the Marid client has a written contract to build against. Verified: `tsc --noEmit` clean; the 10 remaining test files pass (169 assertions); `vite build` completes. The deleted `evidence.test.ts` covered UI claim helpers only — the server-side rules it mirrored stay tested in Julia. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fork governance
🟣 critical · commit
Hypatia scan: 137 finding(s)
panic-attack assail: 19 finding(s)
pons asinorum: 10 finding(s)
rhodibot (RSR compliance): not_run — enrolled, but no report-back was received
panicbot (panic recovery, error handling): not_run — enrolled, but no report-back was received
echidnabot (formal verification: proofs/): not_run — enrolled, but no report-back was received
seambot (integration health: API routes): not_run — enrolled, but no report-back was received
finishingbot (release readiness): not_run — enrolled, but no report-back was received
accessibilitybot (WCAG on the React UI): not_run — enrolled, but no report-back was received
glambot (presentation quality): not_run — enrolled, but no report-back was received
cipherbot: not_applicable — no cryptography is implemented in this repository
sustainabot: not_applicable — fleet adapter slot reserved; no adapter exists yet (gitbot-fleet README)
Scope: static findings reported by each row's tool at the named commit. Purple, red, yellow and blue grade the worst finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |



Removes the React Evidence surface and keeps the Evidence API, per the owner's ruling on #7: the semantics belong to the theory track, and the browser implementation is being rewritten for the Vue/Marid client, so the React one should not sit in the tree in the meantime.
What goes
frontend/src/evidence/(10 files)frontend/src/components/EvidenceModeToggle.tsxapi.evidencenamespace infrontend/src/api/client.tsevidencetab inRunView.tsxWhat stays
src/core/evidence.jl,src/server/routes/evidence.jl,test/unit/test_evidence.jl,test/unit/test_evidence_routes.jl. The claim schema (scope 1–50 values ≤200 chars, text ≤2000, ≤5 warrants, ≤20 caveats, blank status →draft,supportedrequires ≥1 of measurement/citation/inference), the echo verdicts, containment labels and residual arithmetic are untouched and still covered by the Julia suite.Side effect on #7's actual complaint
EvidenceModeTogglegated the placementCladeCumulusPanelin the Trees view — "Evidence Mode currently gates Advanced and CladeCumulus". With the toggle gone that panel renders unconditionally, so the gating the issue describes no longer exists.Contract for the Marid client
The README
### Evidence Mode (API)section now documents the endpoints and the server-enforced validation rules instead of the three removed views.Verification
tsc --noEmit -p .— cleanvite build— succeedsThe deleted
evidence.test.tscovered the UI claim helpers; the rules it mirrored stay tested on the server. This branch is also rebased onto currentmain, and replaces #212 (closed as superseded — every repair it carried landed onmainvia #208–#216).