Skip to content

fix(null_calibration): close SonarCloud follow-up from #267 - #268

Merged
hyperpolymath merged 1 commit into
mainfrom
arena/6bc8a706-metamanifold-webui
Oct 24, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
arena/6bc8a706-metamanifold-webui

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

Follow-up to merged PR #267. Its SonarCloud analysis reported a new-code security rating of C, including a path-traversal finding on the CSV reader's command-line path argument, plus maintainability findings.

  • Have the workflow redirect each known result CSV to the reader's standard input instead of passing a path argument; validate the cell label before using it in an Actions annotation.
  • Remove redundant exception handling and address the R/test maintainability findings without changing the CSV schema, estimator calls, seeds, or formulas.
  • Update REPORT.md to the current calibration.R md5 d47b0fcc96c19349d9223b0515e1a17f. The measured run remains tied to its recorded md5 12a90679f74d2e1a9ab28cec643b5e76.

Validation

  • Python CSV/annotation tests: 4 passed.
  • Manual CLI check: comma, quote, CR and LF in a failure note were preserved/escaped as expected.
  • Comparator workflow YAML parsed; extracted shell passed bash -n; git diff --check passed.
  • SonarCloud Quality Gate passed on this follow-up.
  • The native R CSV-handling and failure-annotation CI steps passed in run 40097171729; the remaining full CI checks are still running.
  • No null-calibration benchmark was rerun.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f5a81ad8-e400-419a-a9d8-a51f7869ae6f
Commits

Reviewing files that changed from the base of the PR and between 2071703 and a343d7b.

Files selected for processing: 6
  • .github/workflows/null-calibration-comparators.yml
  • bench/null_calibration/REPORT.md
  • bench/null_calibration/calibration.R
  • bench/null_calibration/report_failures.py
  • scripts/tests/test_null_calibration_failures.py
  • test/unit/test_null_calibration_csv.R
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T13:13:44.407877Z a343d7b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Fork governance

Lane Status Run
DEED syntax (repo deed) 🟢 conformant run 40097172049
K9 conformance (L0–L2; L3 not verified) green (job: success) same run
Hypatia verdict grid purple (job: success) same run

Hypatia grid purple

🟣 critical · commit a343d7b417d4 · run 40097172049

Reporter Status Critical High Medium Minor Since previous revision
Hypatia scan 🟣 critical 18 29 28 0 — no comparable baseline
panic-attack assail 🔴 high 0 7 1 0 — no comparable baseline
pons asinorum 🟢 clean 0 0 0 0 — no comparable baseline
rhodibot (RSR compliance) 🟠 indeterminate 0 0 0 0 — no comparable baseline
panicbot (panic recovery, error handling) 🟠 indeterminate 0 0 0 0 — no comparable baseline
echidnabot (formal verification: proofs/) 🟠 indeterminate 0 0 0 0 — no comparable baseline
seambot (integration health: API routes) 🟠 indeterminate 0 0 0 0 — no comparable baseline
finishingbot (release readiness) 🟠 indeterminate 0 0 0 0 — no comparable baseline
accessibilitybot (WCAG on the React UI) 🟠 indeterminate 0 0 0 0 — no comparable baseline
glambot (presentation quality) 🟠 indeterminate 0 0 0 0 — no comparable baseline
cipherbot ⚪ not applicable 0 0 0 0 — no comparable baseline
sustainabot ⚪ not applicable 0 0 0 0 — no comparable baseline
Hypatia scan: 75 finding(s)
  • critical cicd_rules/banned_language_file — frontend/src/utils/text.test.ts — TypeScript file detected -- banned language
  • critical cicd_rules/banned_language_file — frontend/src/cladistics/cumulativeLayout.ts — TypeScript file detected -- banned language
  • critical cicd_rules/banned_language_file — frontend/src/cladistics/cumulativeLayout.test.ts — TypeScript file detected -- banned language
  • critical cicd_rules/banned_language_file — frontend/src/api/ijsonJcs.ts — TypeScript file detected -- banned language
  • critical cicd_rules/banned_language_file — frontend/src/api/ijsonJcs.test.ts — TypeScript file detected -- banned language
  • critical cicd_rules/banned_language_file — frontend/src/components/ordinationModel.test.ts — TypeScript file detected -- banned language
  • critical cicd_rules/banned_language_file — frontend/src/components/ordinationModel.ts — TypeScript file detected -- banned language
  • critical cicd_rules/banned_language_file — scripts/tests/test_null_calibration_failures.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — scripts/tests/test_format_readiness.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — scripts/formats/process.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — scripts/formats/probe_kyq.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — scripts/formats/descendants.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — scripts/formats/inventory.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — scripts/formats/conformance.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — test/references/check_ordination_references.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — test/references/check_high_precision_references.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — test/references/exact_summary_reference.py — Python file detected -- banned language
  • critical cicd_rules/banned_language_file — bench/null_calibration/report_failures.py — Python file detected -- banned language
  • high code_scanning_alerts/CSA001 — frontend/src/utils/text.test.ts — Code scanning (Hypatia): hypatia/cicd_rules/banned_language_file -- Hypatia cicd_rules: banned_language_file -- 5 day(s) old
  • high code_scanning_alerts/CSA001 — test/references/exact_summary_reference.py — Code scanning (Hypatia): hypatia/cicd_rules/banned_language_file -- Hypatia cicd_rules: banned_language_file -- 1 day(s) old
  • 55 more; see the structured report in the artifact.
panic-attack assail: 8 finding(s)
  • high DynamicCodeExecution — src/pipeline/dada2/context.jl — eval/Meta.parse in src/pipeline/dada2/context.jl
  • high DynamicCodeExecution — src/analysis/analysis.jl — eval/Meta.parse in src/analysis/analysis.jl
  • high DynamicCodeExecution — src/analysis/differential.jl — eval/Meta.parse in src/analysis/differential.jl
  • high DynamicCodeExecution — src/analysis/ordination.jl — eval/Meta.parse in src/analysis/ordination.jl
  • high DynamicCodeExecution — src/core/provenance.jl — eval/Meta.parse in src/core/provenance.jl
  • high DynamicCodeExecution — scripts/check-julia-syntax.jl — eval/Meta.parse in scripts/check-julia-syntax.jl
  • high DynamicCodeExecution — test/unit/test_permanova.jl — eval/Meta.parse in test/unit/test_permanova.jl
  • medium UnsafeFFI — src/core/memory_probe.jl — 3 ccall/FFI calls in src/core/memory_probe.jl
rhodibot (RSR compliance): not_run — enrolled, but no report-back was received
  • 🟠 indeterminate: enrolled, but no report-back was received
panicbot (panic recovery, error handling): not_run — enrolled, but no report-back was received
  • 🟠 indeterminate: enrolled, but no report-back was received
echidnabot (formal verification: proofs/): not_run — enrolled, but no report-back was received
  • 🟠 indeterminate: enrolled, but no report-back was received
seambot (integration health: API routes): not_run — enrolled, but no report-back was received
  • 🟠 indeterminate: enrolled, but no report-back was received
finishingbot (release readiness): not_run — enrolled, but no report-back was received
  • 🟠 indeterminate: enrolled, but no report-back was received
accessibilitybot (WCAG on the React UI): not_run — enrolled, but no report-back was received
  • 🟠 indeterminate: enrolled, but no report-back was received
glambot (presentation quality): not_run — enrolled, but no report-back was received
  • 🟠 indeterminate: enrolled, but no report-back was received
cipherbot: not_applicable — no cryptography is implemented in this repository
  • ⚪ not applicable: no cryptography is implemented in this repository
sustainabot: not_applicable — fleet adapter slot reserved; no adapter exists yet (gitbot-fleet README)
  • ⚪ not applicable: fleet adapter slot reserved; no adapter exists yet (gitbot-fleet README)

Scope: static findings reported by each row's tool at the named commit. Purple, red, yellow and blue grade the worst finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run.

K9 L0–L2 green

🟢 conformant · commit a343d7b417d4 · run 40097172049 · validator hyperpolymath/standards@c6d78606f392

Category Status Pass Fail Indeterminate N/A Since previous revision
K9 contract typecheck 🟢 conformant 1 0 0 0 — no comparable baseline
K9 validator self-test 🟢 conformant 37 0 0 0 — no comparable baseline
K9 live corpus (L0–L2) 🟢 conformant 3 0 0 0 — no comparable baseline

Scope: K9 components L0–L2 against contract v1.0.0 at the named standards commit. L3 signature verification and routed coordination-dialect files are not certified. Green is limited to this scope. Orange is missing evidence; yellow is grandfathered debt or warnings; grey is an explicit scope exclusion. report.json, badge.json and the validator logs are in the k9-grid artifact on the linked run.

@hyperpolymath
hyperpolymath merged commit 17369b0 into main Oct 24, 2026
26 checks passed
@hyperpolymath
hyperpolymath deleted the arena/6bc8a706-metamanifold-webui branch October 24, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant