Repository navigation
fix(tests): stop test_clade_cumulus.jl pinning SV as a constant - #275
Merged
Merged
Conversation
runtests.jl includes every test file into Main, so the files share one `SV`
binding. Thirteen of them assign it plainly; test_clade_cumulus.jl (unit file
6 of 49) declared it `const`. In Julia 1.12.5 the next plain assignment --
unit file 14, test_validated_statistics.jl:4 -- then dies with
invalid assignment to constant Main.SV
outside any @test, which aborts the enclosing "MetaManifold" testset. Every
file after that point stops running: the remaining 35 unit files, the
occupancy disagreement experiment (included after the unit files), and the
--integration and --server suites.
CI on 8df1041 reports 835 tests; the last green run (2026-10-20) reported
2,967. The required `Occupancy disagreement test` context has been red since
#207 for this reason -- the experiment it is named after never ran, and the
`Validate measured occupancy grades` step was skipped every time.
Drop the const, matching the other thirteen binding sites (this is also the
rule test/occupancy_disagreement_test.jl documents for SV). No other top-level
name is bound in more than one test file.
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Fork governance
🟣 critical · commit
Hypatia scan: 75 finding(s)
panic-attack assail: 8 finding(s)
rhodibot (RSR compliance): not_run — enrolled, but no report-back was received
panicbot (panic recovery, error handling): not_run — enrolled, but no report-back was received
echidnabot (formal verification: proofs/): not_run — enrolled, but no report-back was received
seambot (integration health: API routes): not_run — enrolled, but no report-back was received
finishingbot (release readiness): not_run — enrolled, but no report-back was received
accessibilitybot (WCAG on the React UI): not_run — enrolled, but no report-back was received
glambot (presentation quality): not_run — enrolled, but no report-back was received
cipherbot: not_applicable — no cryptography is implemented in this repository
sustainabot: not_applicable — fleet adapter slot reserved; no adapter exists yet (gitbot-fleet README)
Scope: static findings reported by each row's tool at the named commit. Purple, red, yellow and blue grade the worst finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. 🟢 conformant · commit
Scope: K9 components L0–L2 against contract v1.0.0 at the named standards commit. L3 signature verification and routed coordination-dialect files are not certified. Green is limited to this scope. Orange is missing evidence; yellow is grandfathered debt or warnings; grey is an explicit scope exclusion. report.json, badge.json and the validator logs are in the k9-grid artifact on the linked run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtests.jl includes every test file into Main, so the files share one
SVbinding. Thirteen of them assign it plainly; test_clade_cumulus.jl (unit file 6 of 49) declared itconst. In Julia 1.12.5 the next plain assignment -- unit file 14, test_validated_statistics.jl:4 -- then dies withoutside any @test, which aborts the enclosing "MetaManifold" testset. Every file after that point stops running: the remaining 35 unit files, the occupancy disagreement experiment (included after the unit files), and the --integration and --server suites.
CI on 8df1041 reports 835 tests; the last green run (2026-10-20) reported 2,967. The required
Occupancy disagreement testcontext has been red since #207 for this reason -- the experiment it is named after never ran, and theValidate measured occupancy gradesstep was skipped every time.Drop the const, matching the other thirteen binding sites (this is also the rule test/occupancy_disagreement_test.jl documents for SV). No other top-level name is bound in more than one test file.
Change and reason
Validation
Scope
Contribution checks