Skip to content

docs: correct TEST-NEEDS counts (e2e/property tests and benchmarks exist) - #65

Merged
hyperpolymath merged 13 commits into
mainfrom
arena/cbd1e29d-smtlib-jl
Oct 10, 2026
Merged

hyperpolymath merged 13 commits into
mainfrom
arena/cbd1e29d-smtlib-jl

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

TEST-NEEDS.adoc still claimed 1 test file, 0 benchmarks, 0 e2e tests and no solver-backed tests. Reality (post-#49/#62): test/runtests.jl + test/e2e_test.jl + test/property_test.jl, benches/benchmarks.jl (BenchmarkTools SUITE), and the Z3-backed tests now execute on the ubuntu CI legs. The doc is corrected to match.

Closes #55 (mis-created empty-bodied issue from this session — a permissions probe artifact; superseded by #56). Also fixes the last recon trivia so umbrella #53's AC4 evidence base is honest.

Refs #53.

hyperpolymath and others added 12 commits October 10, 2026 10:22
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
…62)

AGENTS.adoc 'CI & Solver Detection' asks CI to install at least one solver on
PATH. With none installed, every solver-gated test skipped on all 9 matrix
legs — including the Z3 unsat-core path fixed in #49, never exercised in CI.
Ubuntu legs now apt-get install z3 (with a z3 --version execution sentinel);
macos/windows legs keep the documented graceful-skip behaviour.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
…59)

TOOLING-VERSION-INTEGRITY Rule 4: a bare continue-on-error must carry a
GATE DEACTIVATED record or a by-design/advisory rationale within 12 lines.
This one is a by-design best-effort trigger; it now says so. The curl payload
quoting was mangled (the emitted body was not valid JSON); fixed.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
It lists index.md/api.md/examples.md/solvers.md, deleted by the md->adoc
migration (#32); nothing runs Documenter (casket-pages.yml builds the site,
Documenter is not a dependency), and Documenter cannot consume .adoc sources.
Promote-or-delete: the dead script goes. If Documenter HTML API docs are ever
wanted again, that is a new decision, not a reason to keep a broken script.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
….adoc (#61)

The strength is derived from the README (pure-Julia SMT-LIB 2 frontend, one
API over Z3/CVC5/Yices/MathSAT, no FFI, graceful :unknown), not invented.
With the token filled, the ledger's own agent rule applies: delete the file
once no listed token remains anywhere in the tree (grep-verified; the only
other hits are the validator's reject-if-contains strings and the ABI
template's TYPES guidance, which are not substitution tokens).

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Estate canon R2 (CICD-SIGNAL-DISCIPLINE, ratified 2026-09-02): actions.lock
present everywhere, regenerated in the same PR as any uses: change. The
template ships one; this repo never had it (noted in #48's pin notes).

Generated from the merged tree's uses: set (14 workflows, 31 refs, including
job-level reusable-workflow calls such as
hyperpolymath/standards@81dbf2dd...),
in the v0.0.2 format, and verified in both directions against
standards/scripts/check-lock-sync.sh semantics (the checker declared
authoritative over gh actions-lock --verify-local for job-level refs).

Refs #53

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
…laims, restore links

- boj-build.yml: pass github.repository/github.ref_name through env and
  build the JSON with jq --arg (CWE-78 hardening; values are never
  interpolated into the shell).
- methodology.a2ml: the no-solver path raises ErrorException at SMTContext
  construction; :unknown is a check-sat status. Wording corrected.
- ULTRAPLAN-ISSUE-43.adoc: restore the issue/PR cross-references that lost
  their link targets (dangling ']'), and record the post-change green CI
  run 38044880793 with the Z3 install sentinel and solver-backed tests
  executing on the ubuntu legs.
- SMTLIB-AXIOM-PARITY-CHECKLIST.adoc: the docs-build entry pointed at the
  retired docs/make.jl; it now names the supported casket-pages.yml site
  build, and notes Z3-on-ubuntu landed with #62.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
…rena/cbd1e29d-smtlib-jl

# Conflicts:
#	.machine_readable/bot_directives/methodology.a2ml

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
# Conflicts:
#	.github/workflows/boj-build.yml
#	ULTRAPLAN-ISSUE-43.adoc

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
…xist

TEST-NEEDS claimed 1 test file, 0 benchmarks, 0 e2e tests and no
solver-backed tests. runtests.jl + e2e_test.jl + property_test.jl and
benches/benchmarks.jl all exist now; the solver-backed tests run in CI
since #62 installed Z3 on the ubuntu legs.

Closes #55 (mis-created empty-bodied issue from this session; superseded
by #56).

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 57e14564-3c4b-4af8-af7d-0d1186a8f915

📥 Commits

Reviewing files that changed from the base of the PR and between 7b491f0 and 274d235.


📒 Files selected for processing (1)
  • TEST-NEEDS.adoc

 _______________________________________________________________________________________________________________
< Walking on water and developing software from a specification are easy if both are frozen. - Edward V. Berard >
 ---------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 1f40ca2 into main Oct 10, 2026
26 of 27 checks passed
@hyperpolymath
hyperpolymath deleted the arena/cbd1e29d-smtlib-jl branch October 10, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: [repo] Mirror to Git Forges red on every run since 2026-09-20 — owner decision needed: provision the mirror secrets or retire the mirrors

1 participant