[hyperpolymath]

Summary

This fixes two defects in my own change in #622. Both were reported by review bots after it merged, and I reproduced both.

• audit-fix-outcomes.sh dropped repo-grain rows (Codex P2).
  • fix(outcomes): post-merge findings on #616 — parallel counts, aliases, file scope #622 skipped every row with a non-empty file. But dispatch-runner.sh sends . as its explicit repo-root marker for repo-grain fixes (line 247), so those repo-scoped rows were discarded.
  • A single jq definition, repo_scoped, now treats "", . and ./ as repo-scoped. Both the skip count and the replay filter use it.
• ShellCheck could not parse dispatch-runner.sh (CodeRabbit, SC1124).
  • A # shellcheck disable directive inside a case arm is a parse error for ShellCheck, so analysis stopped at that line and everything after it went unchecked. Bash itself runs the script fine.
  • The directive now sits before the case.
  • fix(outcomes): post-merge findings on #616 — parallel counts, aliases, file scope #622's description said "shellcheck: no new findings". That was wrong: the parse error hid the rest of the file.

Validation

• tests/outcome-verdict-test.sh: 38/38 pass.
  • The fixture's shell-quote row now carries "file":".".
  • With the audit fix reverted, 3 checks fail: that row is missing from the replay, it is missing from the NA case, and the skip count reads 2 instead of 1.
• ShellCheck on dispatch-runner.sh now parses the whole file. Its findings match the pre-fix(outcomes): post-merge findings on #616 — parallel counts, aliases, file scope #622 baseline (418ba76) exactly, so the fix adds no new findings. On audit-fix-outcomes.sh there are no new findings; the one SC2016 is annotated, because $f there is a jq variable.
• E1 is unchanged. Across all 21 585 rows of the full E1 outcome log, no file is . or ./, and those are the only values whose classification changed. The replay selection is therefore identical, and the doc's byte-for-byte claim still holds.
• check-lock-sync.sh is clean.

Not done here

CodeRabbit also suggested an integration test that runs the real --parallel dispatch loop; it labelled this Trivial and a heavy lift. Section 8 currently tests the tally and fold helpers on their own. The suggestion has merit, but the loop shells out to Hypatia and the fixers, so a deterministic harness needs stubs for both. I'll raise that separately instead of growing this fix.

The two red checks on #622 come from outside this diff: canon pin drift on rhodibot, and the webpki-roots advisory on gsbot. They are described with proposed fixes in #622's comment. I expect them to stay red here.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PpQVLrCbURpoXtrdvy8V3B

Summary by CodeRabbit

• Bug Fixes
  • Outcome audits now replay repository-scoped entries marked with . or ./, as well as entries without a file specified. Entries that name a specific file are skipped and reported, clarifying which results are included.
• Documentation
  • Updated the replay guidance to explain repository scope and how the report reflects the stated effects of removal and annotation recipes.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The outcome audit now treats "." and "./" as repo-root markers during replay. The E1 fixture and documentation reflect this scope. The change also moves a ShellCheck suppression comment without changing runner behavior.

Changes: Repo-scoped outcome replay

Layer / File(s)	Summary
Repo-scope filtering and replay scripts/audit-fix-outcomes.sh, tests/outcome-verdict-test.sh, docs/experiments/E1-fix-outcome-replay-2026-10-20.adoc, scripts/dispatch-runner.sh	The audit script replays rows with no file, an empty file, ".", or "./", and skips rows naming another file. The fixture and documentation reflect the root markers. The ShellCheck suppression comment moves before the case statement; counter behavior is unchanged.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• hyperpolymath/gitbot-fleet#622: This PR corrects the replay file filter introduced in #622 and also edits the same runner code.
• hyperpolymath/gitbot-fleet#616: This PR changes replay scope and adjusts code in the outcome replay and dispatch implementations.

Merge Risk: Minimal · up to f382a

No actionable merge-blocking risk remains in the reviewed change.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T04:46:47.474159Z	f382af6	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[hyperpolymath]

Two checks fail on 614752c for the same reasons as on #622, and neither touches this diff:

• build · test · clippy (rhodibot): canon pin drift against standards.
• GSBot build, tests and dependency security: the webpki-roots 1.0.7 advisory.

Causes and proposed fixes are in this comment on #622. No fix PR exists yet to port. Codex reviewed this head with no findings.

---

Generated by Claude Code

[hyperpolymath]

Fixes for the two base-red checks are now open as separate PRs, at the owner's choice, so they are not folded in here:

• fix(gsbot): bump three locked deps past blocking RUSTSEC advisories #624 (gsbot). This corrects my earlier proposal. Bumping webpki-roots alone still fails under cargo-deny 0.20.2, because rustls-webpki (RUSTSEC-2026-0382) and tokio (RUSTSEC-2026-0386) also block. fix(gsbot): bump three locked deps past blocking RUSTSEC advisories #624 bumps all three, and the check reports advisories ok.
• chore(rhodibot): re-pin the canon gate table (2f31f46d) #625 (rhodibot). Re-pins the canon gate table; the drift check reports -> ok.

This PR goes green on those two checks once both have merged.

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud