Repository navigation
ci(secret-scan): rename caller job key secret-scan -> scan (D243) - #77
Merged
Merged
Conversation
Secret-Scan-Floor (D243/D244) requires the context `scan / gitleaks` estate-wide. The caller job key here was `secret-scan`, which emits `secret-scan / gitleaks` and can never satisfy the floor. Rename only; the reusable pin and permissions are unchanged. actionlint output identical before and after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
Contributor
|
Warning Review limit reachedThis review ran on the free tier because your account doesn't have an assigned seat on this organization's plan. Waiting won't change this — ask an organization admin to assign you a seat, then retry. Next included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Free Run ID: 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeThe PR author is not assigned a seat. If you are a newly provisioned user and your organization has automatic seat assignment enabled, open a new pull request to trigger seat assignment. Otherwise, ask an organization administrator to assign a seat through the team management page at https://app.coderabbit.ai/settings/team-management. Comment |
20 tasks
9 of 14 tasks
hyperpolymath
added a commit
that referenced
this pull request
Oct 27, 2026
## Summary
Phase 0 of the trope-stack plan ("make the truth legible"): reconcile
this repo's status surfaces with what actually runs, from commands run
in the session that wrote them. Tasks A1–A2 of the Phase 0 brief. One
commit per task. Documentation only.
Sibling PRs: [trope-checker
#102](hyperpolymath/trope-checker#102) ·
[trope-particularity-workbench
#77](hyperpolymath/trope-particularity-workbench#77)
· [hermeneia #76](hyperpolymath/hermeneia#76) ·
[vocarium #42](hyperpolymath/vocarium#42).
Suggested landing order: trope-checker, workbench, this one, hermeneia,
vocarium. Deferred: [#82 A2ML
retirement](#82).
## Changes
- **A1** `README.adoc` — the five-repo map paragraph, verbatim, appended
to "Where it sits — the three-repo picture".
- **A2** `AFFIRMATION.adoc` — a `== As of 2026-10-27` entry from
`TROPECHECK_BIN=<tropecheck-rs> bash tests/check-examples.sh`: 3
examples well-formed, the vendored `design/trope-ir.schema.json` matches
the canonical checker schema, 3 round-trips to the stated verdicts
(`faithful-record` sufficient, `survey-collapse` insufficient at
`e_collapse/fate.quality`, `station-average` sufficient). The honest
scope is kept: no compiler, no LSP, no runtime, O2 stated not
discharged, no proofs. `:revdate:` bumped.
## RSR Quality Checklist
### Required
- [x] Tests pass (`tests/check-examples.sh` → all ok)
- [x] Code is formatted (no code changed)
- [x] Linter is clean (no code changed)
- [x] No banned language patterns
- [x] No `unsafe` blocks without `// SAFETY:` comments (none added)
- [x] No banned functions
- [x] SPDX license headers present on all new/modified source files
- [x] No secrets, credentials, or `.env` files included
### As Applicable
- [ ] `haec_chora.deed` — not applicable (A2ML still in place here;
retirement is issue #82)
- [x] Documentation updated for user-facing changes
- [ ] `docs/architecture/TOPOLOGY.adoc` — architecture unchanged
- [ ] `CHANGELOG` — not touched (docs-only status pass)
- [ ] New dependencies — none
- [ ] ABI/FFI changes — none
## Testing
Run in the session on haec `e9bee39`, 2026-10-27T07:49Z:
```
TROPECHECK_BIN=<tropecheck-rs> bash tests/check-examples.sh
ok faithful-record.haec → faithful-record.ir.json (well-formed IR, expects p-sufficient)
ok survey-collapse.haec → survey-collapse.ir.json (well-formed IR, expects p-insufficient)
ok station-average.haec → station-average.ir.json (well-formed IR, expects p-sufficient)
ok vendored design/trope-ir.schema.json matches the canonical checker schema
ok round-trip faithful-record.ir.json → p-sufficient
ok round-trip survey-collapse.ir.json → p-insufficient (witness e_collapse/fate.quality)
ok round-trip station-average.ir.json → p-sufficient
examples: all lower to valid Trope IR
```
`tropecheck-rs` built from trope-checker `44020f9` (`main` 216f23b plus
the two Phase 0 spec/CI patches, which do not touch `src/rust`).
Not run: nothing else is claimed.
## Owner-only items
- Sign the AFFIRMATION commit on landing.
- A2ML retirement in this repo (issue #82).
## Screenshots
n/a
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01J4QvDh3p24SCUjyM9HHT31
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the secret-scanner caller job key
secret-scan→scanin.github/workflows/secret-scanner.yml, so the check context becomesscan / gitleaks— the context the estate Secret-Scan-Floor ruleset (D243/D244) requires. One-line change; reusable pin, triggers and permissions unchanged. actionlint output is identical before and after.Commit created via GraphQL
createCommitOnBranch(GitHub-signed, signature valid: true).🤖 Generated with Claude Code
https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK