Skip to content

ci: retire the Scorecard Enforcer, which could never pass - #83

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/new-session-ywdrth-retire-scorecard-enforcer
Oct 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/new-session-ywdrth-retire-scorecard-enforcer

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

"OpenSSF Scorecard Enforcer" (.github/workflows/scorecard-enforcer.yml) has failed on every run on main, including 87701b9 before #78–#82 and 230b18e after them. Neither of its gates can pass in this repository:

  • check-critical requires SECURITY.md. The policy here is SECURITY.adoc, as the estate's AsciiDoc rule asks.
  • check-score reads .runs[0].tool.driver.properties.score from the SARIF. Scorecard's SARIF driver carries only name, informationUri, semanticVersion and rules (ossf/scorecard pkg/scorecard/sarif.go), so jq always falls back to 0. The job then fails with "Scorecard score 0 is below minimum 5".

rsr-template-repo carries no enforcer. Scorecard already runs here through scorecard.yml, the standards reusable, which publishes and uploads the results.

Changes

  • Delete .github/workflows/scorecard-enforcer.yml.
  • actions.lock: drop its workflow key, and the three records only it used:
    • actions/download-artifact@v8.0.2
    • actions/upload-artifact@v7.0.2
    • ossf/scorecard-action@v2.5.0
  • github/codeql-action stays for codeql.yml. upload-artifact's v7.0.0 record stays for upload-pages-artifact.

Checks run locally

  • For every workflow, the uses: refs match its lock key exactly. No key is stale, every record is referenced, and no ref lacks a record.
  • bun scripts/check-action-pinning.js: all action refs are pinned (11 resolvable through the lock).
  • validate-actions-lock: passes.
  • No other tracked file names the enforcer.

Not in this PR

scorecard.yml failed on 2026-10-19. Hypatia, Mirror and Secret Scanner fail on main with "invalid lockfile pin", and the estate re-pin to standards 75bd599 (owner-run) clears all four. This PR doesn't widen into that.


Generated by Claude Code

scorecard-enforcer.yml has failed on every run. Its two gates cannot
pass in this repository:

- check-critical requires SECURITY.md. The policy is SECURITY.adoc, as
  the estate's AsciiDoc rule asks.
- check-score reads .runs[0].tool.driver.properties.score from the
  SARIF. Scorecard's SARIF driver carries only name, informationUri,
  semanticVersion and rules (ossf/scorecard pkg/scorecard/sarif.go), so
  jq always falls back to 0 and the gate fails at "0 is below minimum 5".

rsr-template-repo carries no enforcer. Scorecard runs here through
scorecard.yml, the standards reusable, which publishes and uploads the
results. This removes the enforcer and its actions.lock entries: its
workflow key and the records only it used (download-artifact v8.0.2,
upload-artifact v7.0.2, scorecard-action v2.5.0). codeql-action stays
for codeql.yml, and upload-artifact's v7.0.0 record stays for
upload-pages-artifact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y6FD63UrriRBHqmhhEca9t
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 07fe5a1d-7fd4-42b8-abcf-00d9afc51636
📥 Commits

Reviewing files that changed from the base of the PR and between 230b18e and 8592db6.

⛔ Files ignored due to path filters: 1
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing: 1
  • .github/workflows/scorecard-enforcer.yml
💤 Files with no reviewable changes: 1
  • .github/workflows/scorecard-enforcer.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 37
  • GitHub Check: lint
  • GitHub Check: docs
  • GitHub Check: scan / shell-secrets
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: fedora-40
  • GitHub Check: Network Namespace Integration Tests
  • GitHub Check: opensuse-leap-15.5
  • GitHub Check: almalinux-9
  • GitHub Check: archlinux
  • GitHub Check: debian-12
  • GitHub Check: ubuntu-24.04
  • GitHub Check: rockylinux-9
  • GitHub Check: fedora-39
  • GitHub Check: Integration Tests - ubuntu:20.04
  • GitHub Check: ubuntu-20.04
  • GitHub Check: opensuse-tumbleweed
  • GitHub Check: ubuntu-22.04
  • GitHub Check: alpine-3.20
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Integration Tests - ubuntu:24.04
  • GitHub Check: Integration Tests - debian:12
  • GitHub Check: alpine-3.19
  • GitHub Check: lint-workflows
  • GitHub Check: Docker Build Test
  • GitHub Check: Runtime Policy
  • GitHub Check: Installation Test
  • GitHub Check: ShellCheck
  • GitHub Check: Syntax Check
  • GitHub Check: Integration Tests - ubuntu:22.04
  • GitHub Check: check
  • GitHub Check: check
  • GitHub Check: Unit Tests
  • GitHub Check: antipattern-check
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: lint-workflows
📝 Summary

Summary by CodeRabbit

  • Chores
    • Removed the automated OpenSSF Scorecard security checks and related reporting workflow.

The pull request removes the .github/workflows/scorecard-enforcer.yml workflow and its Scorecard checks, reporting, and enforcement settings.

Changes: Scorecard workflow

Layer / File(s) Summary
Remove Scorecard enforcement
.github/workflows/scorecard-enforcer.yml
The workflow and its triggers, permissions, concurrency settings, Scorecard checks, score publication, and SARIF handling were removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: metadatastician

Merge Risk: ⚪ Minimal · up to 8592d

This removes a broken CI enforcement workflow and has no production or user-facing impact. It is safe to merge once the author is satisfied with the reported CI checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: retiring the failing Scorecard Enforcer workflow.
Description check Passed The description directly explains why the Scorecard Enforcer is removed, identifies the affected files and action records, and distinguishes the remaining Scorecard workflow from this change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review October 20, 2026 14:14
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-20T14:14:27.216581Z 8592db6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 20, 2026 14:27
@hyperpolymath
hyperpolymath merged commit c5a0bc5 into main Oct 20, 2026
38 of 42 checks passed
@hyperpolymath
hyperpolymath deleted the claude/new-session-ywdrth-retire-scorecard-enforcer branch October 20, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants