Skip to content

🔧 CodeRabbit CI Fix: Fix seven failing GitHub Actions CI checks #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coderabbitai wants to merge 1 commit into from
Closed

🔧 CodeRabbit CI Fix: Fix seven failing GitHub Actions CI checks #1277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .machine_readable/Debtfile.a2ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,16 @@ forgotten.

## Hygiene

### shell-scripts-missing-spdx
- description: Shell scripts under scripts/ without an SPDX-License-Identifier in the first three lines
- probe: n=0; for f in $(git ls-files 'scripts/*.sh'); do head -3 "$f" | grep -q 'SPDX-License-Identifier' || n=$((n+1)); done; echo "$n"
- count: 0
- ceiling: 1
- severity: medium
- policy: remediable
- tri: eliminate
- accepted-until: 2026-10-01

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a non-expired acceptance date

For any debt measurement run after 2026-10-01, including one at this commit's 2026-10-17 date, run-debtfile.sh marks this newly added entry expired and exits 1 even though its probe reports zero. The weekly .github/workflows/debt-measure.yml job propagates that result as a failed workflow, so this entry immediately introduces a persistent scheduled CI failure.

Useful? React with 👍 / 👎.


### todo-fixme-markers
- description: Files carrying a TODO or FIXME marker. Advisory — a marker is a note to self, not a defect Re-baselined 2026-09-22 (round 2, issue #953): fossilized at 77, measured 80. Probe corrected 2026-10-06: `*.ncl.in` templates are excluded, because their `TODO` fields are placeholders by design (copy, then fill in every TODO), not notes to self; measured 84.
- probe: git grep -I -l -E '\b(TODO|FIXME)\b' -- . ':(exclude).machine_readable/Debtfile.a2ml' ':(exclude)docs/DEBTFILE-SPEC.adoc' ':(exclude)*.ncl.in' | wc -l
Expand All @@ -61,10 +71,10 @@ forgotten.
## Vendored mirrors

### vendored-mirror-unpinned-actions
- description: Unpinned `uses:` refs inside `9-archive/rhodium-standard-repositories/**` -- the vendored mirror of the RSR canon (gitlab.com/hyperpolymath/rhodium-standard-repositories). These are OTHER repositories' workflows reproduced here as templates, and this repo's own CI lock gate (.github/workflows/actions-lock-gate.yml -> .githooks/validate-actions-lock.sh) covers only the root .github tree, so `.githooks/validate-sha-pins.sh` matches that scope and skips the mirror rather than silently passing it. Re-pinning the mirror here fixes no live runner and desynchronises the copy; it is fixed upstream, or the mirror retires. MEASURED 2026-09-21 by the probe.
- probe: n=$(git ls-files '9-archive/rhodium-standard-repositories' | grep -E '/\.github/(workflows|actions)/.*\.ya?ml$' | xargs -r grep -hE '^[[:space:]]*(-[[:space:]]*)?uses:[[:space:]]+[A-Za-z0-9]' | grep -vcE '@[0-9a-f]{40}([^0-9a-f]|$)' || true); echo "${n:-0}"
- count: 40
- ceiling: 40
- description: Unpinned `uses:` refs inside `rhodium-standard-repositories/**` -- the vendored mirror of the RSR canon (gitlab.com/hyperpolymath/rhodium-standard-repositories). These are OTHER repositories' workflows reproduced here as templates, and this repo's own CI lock gate (.github/workflows/actions-lock-gate.yml -> .githooks/validate-actions-lock.sh) covers only the root .github tree, so `.githooks/validate-sha-pins.sh` matches that scope and skips the mirror rather than silently passing it. Re-pinning the mirror here fixes no live runner and desynchronises the copy; it is fixed upstream, or the mirror retires. MEASURED 2026-09-21 by the probe.
- probe: n=$(git ls-files 'rhodium-standard-repositories' | grep -E '/\.github/(workflows|actions)/.*\.ya?ml$' | xargs -r grep -hE '^[[:space:]]*(-[[:space:]]*)?uses:[[:space:]]+[A-Za-z0-9]' | grep -vcE '@[0-9a-f]{40}([^0-9a-f]|$)' || true); echo "${n:-0}"

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the vendored-tree path in the probe

The reviewed tree contains no workflow/action YAML under rhodium-standard-repositories—only two allowlist files—while the actual mirror remains under 9-archive/rhodium-standard-repositories. Consequently this probe reports 0 instead of the 40 unpinned references the previous probe finds, and the scheduled run-debtfile.sh --write pass will falsely lower both the recorded count and ceiling to zero.

Useful? React with 👍 / 👎.

- count: 42
- ceiling: 42

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Declare or revert the debt-ceiling raise

In every PR containing this change against its parent, the pull-request-only Debt ratchet in .github/workflows/governance-reusable.yml compares this ceiling with the previous value of 40. Because the commit messages contain no Debt-exception naming vendored-mirror-unpinned-actions, check-debt-ratchet.sh reports RAISED ... 40 -> 42 and fails the required governance job.

Useful? React with 👍 / 👎.

- severity: low
- policy: flag-only
- tri: eliminate
Expand Down
Loading