Repository navigation
fix: CodeRabbit auto-fixes for PR #783 - #1280
coderabbitai[bot] wants to merge 1 commit into
Conversation
Fixed 2 file(s) based on 1 failed pre-merge check. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🟢 conformant · commit
K9 live corpus (L0–L2): 2 finding(s) / scope notes
Scope: DEED syntax and K9 contracts L0–L2. L3 signature verification and routed coordination dialects are not certified. Green is limited to this scope. Orange is missing evidence; grey is an explicit scope exclusion. Logs and report.json are in the dated conformance-evidence artifact on the linked run. |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d365cdde5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if [ -n "$taxonomy_default" ] && [ "$taxonomy_default" = "$taxonomy_non_default" ]; then | ||
| bad "'$name' taxonomy-default-arm and taxonomy-non-default-arm must name different arms" | ||
| fi | ||
| # Stable-identifier grammar per DEBTFILE-SPEC §Fields: [a-z0-9][a-z0-9._-]*. | ||
| if [ -n "$taxonomy_default" ]; then | ||
| case "$taxonomy_default" in | ||
| *[!a-z0-9._-]*|[^a-z0-9]*) bad "'$name' taxonomy-default-arm '$taxonomy_default' is not a stable identifier ([a-z0-9][a-z0-9._-]*)" ;; | ||
| esac | ||
| fi | ||
| if [ -n "$taxonomy_non_default" ]; then | ||
| case "$taxonomy_non_default" in | ||
| *[!a-z0-9._-]*|[^a-z0-9]*) bad "'$name' taxonomy-non-default-arm '$taxonomy_non_default' is not a stable identifier ([a-z0-9][a-z0-9._-]*)" ;; | ||
| esac | ||
| fi | ||
| fi |
There was a problem hiding this comment.
Removing the arm-identifier checks makes the validator accept values containing spaces or uppercase characters even though DEBTFILE-SPEC.adoc requires [a-z0-9][a-z0-9._-]*. The existing scripts/tests/debtfile-structure-test.sh case with taxonomy-default-arm: Adapt proven test now returns 0 instead of 1, so the canonical shell test suite fails and malformed governance records can pass validation.
Useful? React with 👍 / 👎.
| - taxonomy-default-arm: adapt-proven-idris2-test | ||
| - taxonomy-non-default-arm: write-local-test | ||
| - taxonomy-selected-arm: write-local-test |
There was a problem hiding this comment.
Restore the required taxonomy-choice: non-default and taxonomy-non-default-arm fields here: taxonomy-selected-arm is not defined by the repository's Debtfile specification or recognized by the structural validator. As written, entry() no longer produces the “minimal valid Debtfile entry” its contract promises, so these runner tests exercise inputs that the normal structural gate would reject and the preservation assertion checks a nonexistent field.
Useful? React with 👍 / 👎.
1 participant
This follow-up PR contains CodeRabbit auto-fixes for #783.
Files modified:
scripts/check-debtfile-structure.shscripts/tests/run-debtfile-test.sh