Repository navigation
fix(security): remove unsupported secrets: inherit from the scanner contract; narrow remaining callers (#1108 §6b)
#1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,5 +17,5 @@ jobs: | |
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| uses: hyperpolymath/standards/.github/workflows/scorecard-reusable.yml@210f14e753c80064ec1bcae72f1d654dd9b0e687 | ||
| secrets: inherit | ||
| uses: hyperpolymath/standards/.github/workflows/scorecard-reusable.yml@8ff9ce65f7e54f8d5c5aa94584e2ead0f2ba460f | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When this packaged workflow is installed and runs on a push or schedule, the newly selected Useful? React with 👍 / 👎. |
||
| # No `secrets:` line: the reusable declares none (standards#1108 §6b). | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -333,8 +333,14 @@ These should **call** the reusable workflow instead of copying: | |
| ```yaml | ||
| jobs: | ||
| governance: | ||
| uses: hyperpolymath/standards/.github/workflows/governance-reusable.yml@main | ||
| secrets: inherit | ||
| permissions: | ||
| contents: read | ||
|
Comment on lines
+336
to
+337
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a consumer copies this newly rewritten example, the job-level block grants only Useful? React with 👍 / 👎. |
||
| uses: hyperpolymath/standards/.github/workflows/governance-reusable.yml@<full-40-char-commit-sha> | ||
| # Add a `secrets:` block ONLY when the callee declares named secrets | ||
| # under `workflow_call.secrets`, passing each by name. Never use | ||
| # `secrets: inherit` — it forwards every repo/org secret the caller | ||
| # can see (standards#1108 §6b). Most reusables (e.g. the secret | ||
| # scanner) declare none and need no `secrets:` line at all. | ||
| ``` | ||
|
|
||
| ### For Non-Reusable Workflows | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The local callee's
workflow_callblock declares onlyinputsand still has nosecrets.HYPATIA_SCAN_PATcontract, so passing this named secret causes GitHub to reject every push, pull-request, scheduled, and manual Hypatia run during reusable-workflow validation before any scan job starts. Add the claimed declaration tohypatia-scan-reusable.ymlbefore narrowing this caller.Useful? React with 👍 / 👎.