Repository navigation
fix: pin occupancy-types at its merge commit 8f09c0b - #277
Merged
Merged
Conversation
typed-wasm pinned occupancy-types at 6013483, a commit on the hyperpolymath/occupancy-types#11 branch. That PR was squash-merged as 8f09c0b and its branch deleted. A fresh clone fetches only branches, so it can no longer reach 6013483: fatal: reference is not a tree: 60134839efe2c6f51a31d977a72c1cf94457e71d As a result, the kernel-proofs gate's "Fetch siblings at their pins" step fails on every fresh checkout. 8f09c0b differs from 6013483 only in occupancy-types' own scripts/check-agda.sh; the Agda sources are identical. Also removes a stray "and" from a MinMax.idr header comment. tools/check-kernel-proofs.sh, after a fresh fetch at the new pins: OK (upstream occupancy-types: core proofs and all 2 expected rejections; 33 modules; 11 rejections; 269 equalities in both provers; 4 controls). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6FD63UrriRBHqmhhEca9t
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This fixes
Grade kernel proofs (Idris2 0.8.0 + Agda)on every fresh checkout ofmain.scripts/fetch-siblings.shpins occupancy-types at6013483. That commit sits on the branch of hyperpolymath/occupancy-types#11. #11 was squash-merged as8f09c0bat 11:31Z and its branch deleted.fetch-siblings.shclones and then runsgit fetch origin, which fetches branches only, so6013483is now unreachable:This is task #18 from the MinMax work (#276): move the pin once #11 merged.
Changes
scripts/fetch-siblings.sh: occupancy-types6013483→8f09c0bb319dee99d532e261cd5da4d04ace479a(occupancy-typesmain).scripts/check-agda.sh, which CodeRabbit changed on fix(rhodibot): automated RSR compliance fixes #11.af95728citations inHWM.idr,typed-wasm.ipkgandLEVEL-STATUS.adocname the commit that R-1..R-5 were ported from, so they stay.ResourceAlgebra/MinMax.idr: the header comment "…the identity for alternatives: and an unreachable alternative…" loses its stray "and".CHANGELOG.adoc: an entry.RSR Quality Checklist
Required
tools/check-kernel-proofs.sh, see Testing)unsafeblocks without// SAFETY:commentsbelieve_me/assert_total/assert_smaller/idris_crash).envfiles includedAs Applicable
CHANGELOGor release notes updatedTesting
I ran
_build/dependenciesfrom scratch, the way CI does. The commands werescripts/fetch-siblings.sh, thentools/check-kernel-proofs.sh, with Idris2 0.8.0 and Agda 2.6.3:🤖 Generated with Claude Code
https://claude.ai/code/session_01Y6FD63UrriRBHqmhhEca9t
Generated by Claude Code