assess: preserve stale flask-request-reader branch (2021) - #25
Closed
thorwhalen wants to merge 1 commit into
Closed
thorwhalen wants to merge 1 commit into
thorwhalen wants to merge 1 commit into
Conversation
Member
Author
|
Preserved via this PR's diff; deleting the stale branch ref (see PR body for the assessment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assessment, not a merge request
Preserving a stale (2021-11-08, 5 years old), never-PR'd branch from an external contributor (Steve Herzog, analog.com) before deleting the raw ref, per the fleet's stale-branch cleanup convention.
Content: `stream2py/sources/flask_request.py` (61 lines) — a `FlaskRequestReader(SourceReader)` that reads from an in-flight Flask request. Self-contained, no other files touched, no tests,
flasknot declared as a dependency anywhere in the branch.Not merging: no tests, no CI run against it (predates the current wads-based CI entirely -- based on a pre-pyproject.toml tree),
flaskwould need to become an optional/extras dependency, and there's no way to verify it still matches the currentSourceReaderinterface without dedicated review. Real, plausibly-useful example code, not obviously wrong -- worth a look if a Flask-based source reader is ever wanted, but not something to land unattended.Closing this PR immediately after opening it; the commit stays reachable via this PR's diff and merge-base even after the raw branch ref is deleted.
🤖 Generated with Claude Code
https://claude.ai/code/session_011HSBVhDjRU4apSLcRkavv9