Skip to content

assess: preserve stale flask-request-reader branch (2021) - #25

Closed
thorwhalen wants to merge 1 commit into
masterfrom
assess/flask-request-reader
Closed

thorwhalen wants to merge 1 commit into
masterfrom
assess/flask-request-reader

Conversation

@thorwhalen

Copy link
Copy Markdown
Member

Assessment, not a merge request

Preserving a stale (2021-11-08, 5 years old), never-PR'd branch from an external contributor (Steve Herzog, analog.com) before deleting the raw ref, per the fleet's stale-branch cleanup convention.

Content: `stream2py/sources/flask_request.py` (61 lines) — a `FlaskRequestReader(SourceReader)` that reads from an in-flight Flask request. Self-contained, no other files touched, no tests, flask not declared as a dependency anywhere in the branch.

Not merging: no tests, no CI run against it (predates the current wads-based CI entirely -- based on a pre-pyproject.toml tree), flask would need to become an optional/extras dependency, and there's no way to verify it still matches the current SourceReader interface without dedicated review. Real, plausibly-useful example code, not obviously wrong -- worth a look if a Flask-based source reader is ever wanted, but not something to land unattended.

Closing this PR immediately after opening it; the commit stays reachable via this PR's diff and merge-base even after the raw branch ref is deleted.

🤖 Generated with Claude Code

https://claude.ai/code/session_011HSBVhDjRU4apSLcRkavv9

@thorwhalen

Copy link
Copy Markdown
Member Author

Preserved via this PR's diff; deleting the stale branch ref (see PR body for the assessment).

@thorwhalen thorwhalen closed this Sep 22, 2026
@thorwhalen
thorwhalen deleted the assess/flask-request-reader branch September 22, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant