Repository navigation
fix: pass param_to_prop_type to ju; skip *args/**kwargs in form schemas (#9) - #11
Merged
Merged
Conversation
…as (#9) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…review) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9.
param_to_prop_typegiven toFunctionSpecStore/mk_rjsf_appis now passed toju.rjsf.func_to_form_spec(an explicitrjsf_config['param_to_prop_type']wins;Noneleaves ju's default).*args/**kwargsare dropped from the schema (propertiesandrequired) and the uiSchema, in the ju path (using ju's owni2.Signaming) and in the basic fallback; ju's first-field autofocus moves to the first remaining field.uf has no dependents (
priv test-dependents uf --transitive: only uf, passes, same as master).Adversarial review (fresh Opus subagent) confirmed two issues (variadic name mismatch between inspect and i2.Sig for builtins like print; stale uiSchema key) - both fixed with tests. Its pre-existing findings are filed as a follow-up issue.
🤖 Generated with Claude Code