Skip to content

Upgrade AWS SDK - #667

Merged
binh-dam-ibigroup merged 36 commits into
devfrom
upgrade-aws
Sep 9, 2026
Merged

Upgrade AWS SDK#667
binh-dam-ibigroup merged 36 commits into
devfrom
upgrade-aws

Conversation

@binh-dam-ibigroup

@binh-dam-ibigroup binh-dam-ibigroup commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR upgrades AWS SDK to version 2.x. The largest benefit of upgrading is AWS access using federated (SSO) login during development without having to use temporary access keys. Existing access-key-based access should still work. Also, AWS SDK 1.x is out of support now.

Things to test:

  • Import a feed version and download that feed version (using a config where application.data.use_s3_storage = true).
  • Deploy an OTP instance (using a config where modules.deployment.enabled = true

@binh-dam-ibigroup
binh-dam-ibigroup marked this pull request as draft August 21, 2026 12:37
@br648 br648 removed their assignment Sep 1, 2026
@binh-dam-ibigroup

Copy link
Copy Markdown
Contributor Author

@miles-grant-ibigroup and @daniel-heppner-ibigroup in case you are interested by the changes in upgrading AWS SDK.

@binh-dam-ibigroup

Copy link
Copy Markdown
Contributor Author

A few minor comments. AWS related tests pass, I'm assuming actual AWS end to end testing using DT have been carried out on a test environment.

@br648 I had not when first submitting the PR, but now we have a successful E2E test run with this PR's code:
ibi-group/datatools-ui#1068

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update build-docker.yml to build a docker image for this branch? Then we can test on a real server

@binh-dam-ibigroup

Copy link
Copy Markdown
Contributor Author

Should we update build-docker.yml to build a docker image for this branch? Then we can test on a real server

Good idea (81aeb19)

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working on a real server. Thanks so much for figuring this out!

Comment thread .github/workflows/build-docker.yml Outdated
@binh-dam-ibigroup

Copy link
Copy Markdown
Contributor Author

@br648 and @miles-grant-ibigroup Requesting approvals again after stale code rule.

@binh-dam-ibigroup
binh-dam-ibigroup merged commit 13de1c1 into dev Sep 9, 2026
6 checks passed
@binh-dam-ibigroup
binh-dam-ibigroup deleted the upgrade-aws branch September 9, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants