Upgrade AWS SDK - #667
Conversation
|
@miles-grant-ibigroup and @daniel-heppner-ibigroup in case you are interested by the changes in upgrading AWS SDK. |
@br648 I had not when first submitting the PR, but now we have a successful E2E test run with this PR's code: |
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Should we update build-docker.yml to build a docker image for this branch? Then we can test on a real server
Good idea (81aeb19) |
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Everything is working on a real server. Thanks so much for figuring this out!
This reverts commit 81aeb19.
|
@br648 and @miles-grant-ibigroup Requesting approvals again after stale code rule. |
Checklist
devbefore they can be merged tomaster)Description
This PR upgrades AWS SDK to version 2.x. The largest benefit of upgrading is AWS access using federated (SSO) login during development without having to use temporary access keys. Existing access-key-based access should still work. Also, AWS SDK 1.x is out of support now.
Things to test:
application.data.use_s3_storage = true).modules.deployment.enabled = true