Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User already existsand currentUser has already registeredprovider messages, including the legacy JSON-string response.Validation
Using the repository-pinned Flutter 3.35.3 / Dart 3.9.2:
cd packages/ion_identity_client && flutter test --no-pub test/core/types/user_already_exists_exception_test.dart test/auth/services/register/existing_account_registration_test.dart --reporter expanded: 30 passed. The service tests exercise NetworkClient through registration-init and fail on any signer/token-storage mutation.flutter test --no-pub --no-test-assets test/app/features/auth/flows/return_to_existing_account_login_test.dart --reporter expanded: 1 passed. The test disables material splash shaders because the private app asset bundle is unavailable.git diff --check: passed.Review And Release Gate
Implementer reviewed commit
7466c96c62568b7b982a65617b682ad0381abcb1: no blocking logic/security findings in the scoped diff. This does not bypass authentication or recover an inaccessible credential.Draft: complete signup-screen analysis/build and real-device passkey/password/2FA QA remain required. The public checkout lacks generated Riverpod/assets sources and private
assets/ion_identity/coins.json; full signup-screen analysis and the default asset-bundled test invocation could not pass in this environment. No fake environment/assets were created. No new GitHub workflows or hosted requirements were added.A registered provider account with a lost credential still requires valid existing credentials or a separately authorized provider recovery procedure; this UI compatibility patch does not reset it.