Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new ROUTE-SET definition is internally inconsistent with later text and needs small citation/wording fixes to align the section’s statements.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR expands the document’s “Prefix Filters Created from Internet Routing Registries (IRRs)” guidance to explicitly cover ROUTE-SET objects and reorganizes the IRR prefix filtering discussion into clearer subsections (ROUTE-SETs, route objects, AS-SETs, filter computation, filter management, and hierarchical scoping).
Changes:
- Adds a new ROUTE-SET subsection explaining ROUTE-SET purpose, prefix-range operators, and operational examples.
- Refactors and clarifies ROUTE/ROUTE6 and AS-SET descriptions and updates citations (including adding RFC 2622 to references).
- Splits management/refresh guidance and “conflicting data + hierarchical naming” guidance into dedicated subsections.
File summaries
| File | Description |
|---|---|
| draft-ietf-grow-routing-ops-sec-inform.xml | Adds ROUTE-SET coverage and restructures the IRR prefix-filtering section with updated references and scoping guidance. |
Review details
Suppressed comments (1)
draft-ietf-grow-routing-ops-sec-inform.xml:520
- There are two spaces after the period before “However,” which is inconsistent with the surrounding formatting.
ROUTE-SETs may contain AS numbers and AS-SETs, which must be mapped to prefixes using the process above. However, ROUTE-SETs that do not include ASes or AS-SETs are independent of ROUTE/ROUTE6 objects and do not require the mapping described above.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <name>ROUTE-SETs</name> | ||
| <t> | ||
| ROUTE-SETs are used to specify sets of prefixes in import and export RPSL policies, and can be used to generate BGP import and export filters. | ||
| ROUTE-SETs are objects that contain prefix ranges <xref target="RFC2622" format="default" section="2"/> and other ROUTE-SETs <xref target="RFC4012" format="default" section="4.2"/>. |
| These operators allow for more compact specification of prefix sets in complex configurations. | ||
| </t> | ||
| <t> | ||
| An operator can define ROUTE-SET objects for the routes it plans to announce to neighbors. |
edit: add RFC2622 to references
Toning down "purpose" of AS-SETs into "common use case", and dropping ROUTE/ROUTE6 objects as "the cornerstone" of IRR-based filtering. Extended reasoning: My operational practice managing IRR objects for the PEERING Research Testbed (AS47065) is that ROUTE-SETs are significantly more flexible and easier to manage than the AS-SETs and ROUTE/ROUTE6 combo widely employed by operators today. This RFC is an opportunity to steer operators towards ROUTE-SETs and possibly improve operational practice. ROUTE-SETs allow precise specification of prefixes via RPSL prefix-range operators, and an AS can define multiple ROUTE-SETs for different peering relationships. ROUTE/ROUTE6 objects are not hierarchical, have few contraints on who can create them, and do not support range operators. As AS added as a member of an AS-SET contributes the exact same of routes to a prefix, which implies that AS-SETs cannot define different sets of prefixes better suited to different peering relationships. RPSL allows operators to specify import and export rules using the following syntax (in aut-num objects): mp-import: from <PEER> import <FILTER> mp-export: to <PEER> export <FILTER> I would argue that AS-SETs are better fit for specifying the <PEER> part of import/export rules (which is usually just an ASN), and that ROUTE-SETs are a better fit for the <FILTER> part of import/export rule. The only limitation I can think of ROUTE-SETs relative to the AS-SET plus ROUTE combo is that ROUTE-SETs alone do not allow AS-path-based filters that check that the originator of an announcement is within a given AS-SET. This does not seem like a significant loss: (1) I would guess that few operators configure AS-path-based filters, and (2) the RFC should recommend that operators deploy ROV for origin validation instead of ROUTE/ROUTE6 objects.
|
LLM jumped the gun during revision pass. Will open a new one after fixes. |
Adds coverage of ROUTE-SET objects to the "Prefix Filters Created from IRRs" section:
This PR is stacked on top of #18 (branch
minor-edits). Until that PR merges, the diff below includes its commits as well; once merged, GitHub will automatically show only the ROUTE-SET changes.💘 Generated with Crush
Assisted-by: Crush:glm-5.3