Skip to content

Minor clarifications or fixes to IRR-based filtering section - #20

Merged
ichdasich merged 5 commits into
ichdasich:mainfrom
cunha:minor-edits
Oct 2, 2026
Merged

ichdasich merged 5 commits into
ichdasich:mainfrom
cunha:minor-edits

Conversation

@cunha

@cunha cunha commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 22, 2026 22:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated ROUTE/ROUTE6 wording introduces an ambiguity that can be read as conflicting with exact-match semantics, and there is a grammatical error in the updated “originated” sentence.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR refines the document’s IRR-based filtering discussion by clarifying ROUTE/ROUTE6 object semantics, improving wording in the recursive filter computation text, and adding a missing citation.

Changes:

  • Updates IRR section cross-references and clarifies wording around IRR data reliability.
  • Rewrites the “Route Objects” text to be more explicit about ROUTE/ROUTE6 mappings and exact-match semantics.
  • Adds an in-text citation to RFC2622 (and includes it in the bibliography).
File summaries
File Description
draft-ietf-grow-routing-ops-sec-inform.xml Editorial clarifications to the IRR-based filtering section; adds RFC2622 reference and improves phrasing/semantics around ROUTE/ROUTE6 and recursive filter computation.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@ichdasich ichdasich left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR! I just went over it, and there are some small things to address before merging. Could you maybe take a look? Thanks!

<xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.1191.xml"/>
<xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.1918.xml"/>
<xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.1997.xml"/>
<xi:include href="https://xml2rfc.ietf.org/public/rfc/bibxml/reference.RFC.2622.xml"/>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a reference to 2622 being added in this commit; Is there already one that was missing the reference?

@cunha cunha Sep 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a reference to it in line 494 (previously 492) when describing how to convert an AS-SET into a set of prefixes:

Using AS-SETs and ROUTE/ROUTE6 objects, it is possible to use the IRR information to build, for a given neighbor AS, a list of prefixes the neighbor is authorized to originate or transit <xref target="RFC2622" format="default" section="5.3"/>.

@cunha

cunha commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! Pushed a commit with the suggested fixes.

@cunha
cunha requested a review from ichdasich September 22, 2026 15:05

@ichdasich ichdasich left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ichdasich
ichdasich merged commit 0e7fce3 into ichdasich:main Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants