Skip to content

Fix helium material wording in pin-cell notebooks - #1014

Merged
tjlaboss merged 2 commits into
idaholab:developfrom
Sardor-tracker:fix-helium-material-wording
Oct 8, 2026
Merged

tjlaboss merged 2 commits into
idaholab:developfrom
Sardor-tracker:fix-helium-material-wording

Conversation

@Sardor-tracker

@Sardor-tracker Sardor-tracker commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Description

The Goal 2 task list says to create a helium cell, although the gas-gap cell already exists. Change “helium cell” to “helium material” in both the exercise and answer notebooks so the task agrees with the later material creation and assignment.

Fixes #1013

Validation

  • Both updated notebooks parse as valid JSON.
  • Compared the saved branch files with the originals: exactly one Markdown line changes in each notebook.
  • Code cells, outputs, metadata, and notebook structure are unchanged.
  • Notebooks were not executed; this change only corrects instructional text.

General Checklist

  • I have performed a self-review of the changes.
  • The change is limited to the wording described in the issue.
  • Black formatting — not applicable; no Python code changed.
  • New tests — not applicable; documentation wording only.

LLM Disclosure

Sardor is a human contributor. Codex assisted with a two-word documentation correction and the PR description; no executable code was generated.

Were any large language models used to generate this change?

  • Yes — OpenAI Codex
  • No

Documentation Checklist

No classes, functions, interfaces, infrastructure, or behavior were added or changed. The affected tutorial instructions are updated in both notebook versions.


📚 Documentation preview 📚: https://montepy--1014.org.readthedocs.build/en/1014/

@MicahGale

Copy link
Copy Markdown
Collaborator

Which specific model did you use in Codex?

@MicahGale MicahGale added the documentation Improvements or additions to documentation label Oct 7, 2026
@MicahGale MicahGale self-assigned this Oct 7, 2026
@MicahGale
MicahGale self-requested a review October 7, 2026 14:51

@MicahGale MicahGale left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice simple update.

@Sardor-tracker

Copy link
Copy Markdown
Contributor Author

Which specific model did you use in Codex?

gpt-6.1-sol

@Sardor-tracker

Sardor-tracker commented Oct 7, 2026 via email

Copy link
Copy Markdown
Contributor Author

@tjlaboss
tjlaboss merged commit eab259c into idaholab:develop Oct 8, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change “helium cell” to “helium material” in the pin-cell instructions

3 participants