Repository navigation
Give estimate() a correct standard error and keep bootstrap replicates - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The g-computation SE was the spread of the unit-level effects, which ignores uncertainty in the outcome model: for an additive glm it was exactly 0 with a zero-width CI. With model = "glm" the normal interval now uses a delta-method SE of the contrast (plus the sampling variance of the averaged effects for ATE/ATT); it matches the lm SE of the treatment coefficient for a linear model (0.0479 in the reported repro). Other learners, and interval = "bootstrap", use the SD of n_boot nonparametric bootstrap refits. $bootstrap now keeps the replicate estimates and their SD. Tests added.