fixes #242: Use SystemProperties rather than JiveGlobals to resolve config keys in the first instance - #243
Merged
Conversation
…s to resolve config keys in the first instance
Fishbowler
force-pushed
the
fix-system-properties
branch
from
August 31, 2026 19:40
cd622a5 to
d4a30b7
Compare
Member
|
Does this need a test for a SystemProperty that doesn't have an explicit value, and a |
Member
|
I've pushed another commit that attempts to deal with |
Using the older JiveGlobals, a `null` value cannot differentiate between the property not existing, or existing but having a null value. Traditionally, this code assumed 'property does not exist'. With SystemProperty, we can make the distinction (based on `SystemProperty#isPresent()`). Thus, the service need not default to 'NOT FOUND' when encountering a null value.
guusdk
force-pushed
the
fix-system-properties
branch
from
September 8, 2026 18:11
71380d9 to
0d677d7
Compare
Member
|
I've amended my commit to add a hurl test for a SystemProperty with a known null default. |
guusdk
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242
Resolution runs through System Properties first (which might return a default), but if it returns nothing, try a Jive Global instead.