Skip to content

chore: stop naming mode in indexing.R#2732

Open
maelle wants to merge 1 commit into
mainfrom
indexing
Open

chore: stop naming mode in indexing.R#2732
maelle wants to merge 1 commit into
mainfrom
indexing

Conversation

@maelle

@maelle maelle commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

One of those was unused. It seemed clearer not to name any?

One of those was unused. It seemed clearer not to name any?
@maelle maelle requested a review from schochastics July 6, 2026 07:06
@maelle

maelle commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Hide white space in the diff otherwise it's not helpful 😺

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7db27b0 is merged into main:

  • ✔️as_adjacency_matrix: 850ms -> 853ms [-1.14%, +1.81%]
  • ✔️as_biadjacency_matrix: 807ms -> 808ms [-1.83%, +2.18%]
  • ✔️as_data_frame_both: 1.63ms -> 1.65ms [-1.43%, +3.9%]
  • ✔️as_long_data_frame: 4.11ms -> 4.15ms [-3.97%, +6%]
  • ✔️es_attr_filter: 2.92ms -> 2.94ms [-2.89%, +4.27%]
  • ✔️graph_from_adjacency_matrix: 155ms -> 154ms [-2.54%, +0.61%]
  • ✔️graph_from_data_frame: 3.57ms -> 3.6ms [-1.16%, +2.56%]
  • ✔️vs_attr_filter: 1.69ms -> 1.64ms [-7.19%, +1.51%]
  • ✔️vs_by_name: 1.17ms -> 1.14ms [-6.81%, +2.41%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants