Repository navigation
set-tester-from-report-creator enables to use the report creator as tester in Robot executions. - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the manifest error handling and skipped-test tester preservation issues, and clarify the fallback documentation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds an opt-in configuration and CLI option to assign the TestBench report creator as tester for executed Robot test cases.
Changes:
- Parses report creator data from
manifest.json. - Assigns tester information to execution results.
- Adds configuration, CLI, API support, tests, and documentation.
| File | Description |
|---|---|
tests/test_report_creator_tester.py |
Tests creator parsing, configuration, and tester assignment. |
testbench2robotframework/testbench2robotframework.py |
Supports configuration instances. |
testbench2robotframework/robotframework2testbench.py |
Supports configuration instances. |
testbench2robotframework/result_writer.py |
Reads creators and assigns testers. |
testbench2robotframework/config.py |
Adds the tester-assignment option. |
testbench2robotframework/cli.py |
Adds the CLI flag. |
testbench2robotframework/__init__.py |
Updates the package version. |
docs/usage/fetch_results.md |
Documents tester assignment. |
docs/configuration/overview.md |
Documents configuration and behavior. |
The implementation requires changes for malformed or unreadable manifests, preservation of existing testers on skipped tests, and clarification of the documented fallback behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+215
to
+217
| report_creation = manifest.get("reportCreation") if isinstance(manifest, dict) else None | ||
| creator = (report_creation or {}).get("creator") or {} | ||
| user_key = creator.get("userKey") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.