Skip to content

[Feat] QA반영 임차민 (코드리뷰) #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckals413 merged 1 commit into from
Sep 7, 2026
Merged

[Feat] QA반영 임차민 (코드리뷰) #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/src/main/java/com/flint/android/presentation/collectionlist/CollectionListScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ fun CollectionListRoute(
modifier = Modifier.padding(paddingValues),
title = uiState.appbarTitle,
routeType = uiState.routeType,
isMyProfile = uiState.userId == null,
onBackClick = navigateUp,
onCollectionItemClick = navigateToCollectionDetail,
onBookmarkClick = viewModel::toggleCollectionBookmark,
Expand Down Expand Up @@ -111,6 +112,7 @@ private fun CollectionListScreen(
onBackClick: () -> Unit,
title: String,
routeType: CollectionListRouteType,
isMyProfile: Boolean,
collectionList: UiState<CollectionListModel>,
onCollectionItemClick: (collectionId: String) -> Unit,
onBookmarkClick: (collectionId: String) -> Unit,
Expand Down Expand Up @@ -147,7 +149,7 @@ private fun CollectionListScreen(
) {
Spacer(Modifier.height(12.dp))

val displayCount = if (routeType == CollectionListRouteType.SAVED) {
val displayCount = if (routeType == CollectionListRouteType.SAVED && isMyProfile) {
collections.count { it.isBookmarked }
Comment thread
coderabbitai[bot] marked this conversation as resolved.
} else {
collections.size
Expand Down Expand Up @@ -216,6 +218,7 @@ private fun CollectionListScreenPreview() {
onBackClick = {},
title = "전체 컬렉션",
routeType = CollectionListRouteType.CREATED,
isMyProfile = true,
collectionList = UiState.Success(CollectionListModel.FakeList),
onCollectionItemClick = {},
onBookmarkClick = {},
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/java/com/flint/android/presentation/collectionlist/CollectionListViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ class CollectionListViewModel @Inject constructor(
init {
val routeReceiveData = savedStateHandle.toRoute<Route.CollectionList>()
setAppBarTitle(routeReceiveData.routeType.title)
_uiState.update { it.copy(routeType = routeReceiveData.routeType) }
_uiState.update {
it.copy(routeType = routeReceiveData.routeType, userId = routeReceiveData.userId)
}
getCollectionList(routeReceiveData)
observeCollectionDeletions()
}
Expand Down
1 change: 1 addition & 0 deletions .../main/java/com/flint/android/presentation/collectionlist/uistate/CollectionListUiState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ import com.flint.android.domain.model.collection.CollectionListModel
data class CollectionListUiState(
val appbarTitle: String = "",
val routeType: CollectionListRouteType = CollectionListRouteType.CREATED,
val userId: String? = null,
val collectionList: UiState<CollectionListModel> = UiState.Loading
)
Loading