Repository navigation
fix(starter): pin compatible Vite release - #127
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Phaser example and generated starters now pin Vite 8.1.3, bound ChangesPhaser starter hardening
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a6d1e1d to
43a1936
Compare
|
@codex review 최신 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/validate-starter-workflow.ts`:
- Around line 317-343: Update the Vite version validation in the package-path
loop to compare every devDependencies.vite value directly against the fixed
baseline 8.1.3, rather than initializing and reusing expectedVersion from the
first manifest. Remove the first-value baseline logic while preserving the
existing format validation and failure reporting.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 834852a0-92c4-478e-823a-c631c9501abb
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
.sampo/changesets/bound-starter-vite-plugin-type.md.sampo/changesets/pin-generated-vite.md.sampo/changesets/render-starter-entry-failure.mdexamples/phaser-starter/package.jsonexamples/phaser-starter/src/entry.tsexamples/phaser-starter/src/gameEntry.tsexamples/phaser-starter/src/runtime/renderEntryFailure.tsexamples/phaser-starter/vite.shared.tspackages/cli/templates/phaser-game/apps/target-ait/package.jsonpackages/cli/templates/phaser-game/apps/target-cloudflare-pages/package.jsonpackages/cli/templates/phaser-game/apps/target-devvit/package.jsonpackages/cli/templates/phaser-game/package.jsonpackages/cli/templates/phaser-game/src/entry.tspackages/cli/templates/phaser-game/src/gameEntry.tspackages/cli/templates/phaser-game/src/runtime/renderEntryFailure.tspackages/cli/templates/phaser-game/vite.shared.tstools/validate-starter-workflow.ts
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review CodeRabbit의 Vite baseline 지적을 |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
@mpgd/cliWhy
Fresh standalone games resolved
vite: ^8.1.3to newer patch releases. Vite 8.1.5 causes TypeScript 7 RC to exceed its recursive comparison depth while checking the@ttsc/unpluginand target-wrapper plugin types, so an untouched generated game failspnpm checkimmediately.Validation
pnpm validate:starter-workflowpnpm --dir examples/phaser-starter check@mpgd/*packages, and passed root, Devvit, Cloudflare Pages, and Apps in Toss checks plus the production Vite buildpnpm checkgit diff --checkocr review --audience agent --commit 8e42df2completed with no findingsSummary by CodeRabbit
Bug Fixes
Compatibility
Validation