Skip to content

Support deployed generic web runtimes - #128

Merged
imjlk merged 3 commits into
mainfrom
codex/generic-web-runtime
Aug 8, 2026
Merged

imjlk merged 3 commits into
mainfrom
codex/generic-web-runtime

Conversation

@imjlk

@imjlk imjlk commented Aug 7, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • add generic web runtime and release profile contracts
  • allow game-owned browser adapters to expose server-backed commerce, identity, ads, and leaderboards
  • map generic web targets to browser viewport and artifact metadata
  • document the distinction between local web preview and deployed web runtimes

Why

Configured web targets previously reused the local preview policy, which rejected production integrations even when a game-owned adapter implemented them.

Validation

  • pnpm check
  • pnpm smoke:target-config-extensions
  • pnpm smoke:cli-configured-web-targets
  • pnpm --filter @mpgd/target-config test
  • OCR review: zero findings; two trivial files completed with OCR delegate review after provider rate limiting

Summary by CodeRabbit

  • New Features

    • Added support for deployed web targets with the web runtime and release profile.
    • Enabled web platform integrations such as commerce, identity, advertising, and leaderboards.
    • Updated starter configurations to support deployed web builds.
  • Documentation

    • Clarified the distinction between deployed web targets and local web-preview development targets.
  • Bug Fixes

    • Improved validation to reject incompatible runtime and release-profile combinations.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@imjlk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f159ea8-1c22-4ff1-a2f8-2ed3b8708df2

📥 Commits

Reviewing files that changed from the base of the PR and between c6f1ad2 and d2924f9.

📒 Files selected for processing (6)
  • docs/GAME_DEVELOPMENT.md
  • packages/cli/src/production-target-readiness.ts
  • packages/cli/templates/phaser-game/README.md
  • tools/smoke/production-target-readiness.ts
  • tools/smoke/target-config-extensions.ts
  • tools/target/target-config-matrix.ts
📝 Walkthrough

Walkthrough

The PR adds web as a runtime and release profile. It updates platform, adapter, viewport, matrix, template, documentation, and smoke-test handling for deployed game-owned web targets.

Changes

Deployed web runtime support

Layer / File(s) Summary
Web runtime contracts and templates
packages/target-config/src/runtime.ts, examples/phaser-starter/..., packages/cli/templates/phaser-game/..., docs/GAME_DEVELOPMENT.md, .sampo/changesets/...
The public unions and Phaser configurations include web. The guidance distinguishes deployed web targets from local web-preview targets.
Web runtime resolution
tools/target/effective-config.ts, packages/target-config/src/viewport.ts, tools/target/target-config-matrix.ts
The web runtime maps to platform kind web, browser adapter, and embedded-webview. Custom targets accept web leaderboards.
Deployed web configuration validation
tools/smoke/target-config-extensions.ts, packages/target-config/test/target-config-smoke.ts
Smoke tests validate deployed web configurations, reject incompatible release profiles, and use web for desktop browser viewport planning.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

sequenceDiagram
  participant GameConfig
  participant EffectiveConfig
  participant TargetConfigMatrix
  participant SmokeTests
  GameConfig->>EffectiveConfig: Resolve the web runtime
  EffectiveConfig-->>GameConfig: Return web platform kind and browser adapter
  GameConfig->>TargetConfigMatrix: Validate deployed web features
  TargetConfigMatrix-->>GameConfig: Accept web leaderboard configuration
  SmokeTests->>GameConfig: Load and round-trip the target
  SmokeTests-->>GameConfig: Reject web with web-preview profile
Loading

Possibly related PRs

  • imjlk/mpgd-kit#17: Extends browser-based target configuration and effective platform mappings.
  • imjlk/mpgd-kit#31: Updates viewport handling and smoke tests for web runtime support.
  • imjlk/mpgd-kit#125: Adds related configured web-target handling across target configuration paths.

Poem

A rabbit hops through web-bound code,
With browser maps along the road.
web now joins the runtime queue,
While previews keep their purpose true.
Smoke tests guard each matching pair.
Release notes flutter in the air.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: support for deployed generic web runtimes.
Description check ✅ Passed The description explains the changes, rationale, and validation, but it uses different headings and omits the template checklist format.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/generic-web-runtime

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6f1ad2d29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/target/target-config-matrix.ts Resolved
@imjlk

imjlk commented Aug 7, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4dc5e394fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/target/target-config-matrix.ts Resolved
@imjlk

imjlk commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: d2924f9bdb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@imjlk
imjlk merged commit 904b82e into main Aug 8, 2026
2 checks passed
@imjlk
imjlk deleted the codex/generic-web-runtime branch October 27, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant