Repository navigation
chore: split generated Devvit init auth modes - #13
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR splits the Devvit ChangesDevvit Init Auth Mode Split
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8b00c8e4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "scripts": { | ||
| "init": "devvit upload --copy-paste --config devvit.json", | ||
| "init": "devvit upload --config devvit.json", | ||
| "init:copy-paste": "devvit upload --copy-paste --config devvit.json", |
There was a problem hiding this comment.
Make the init fallback use the wizard copy-paste path
With the pinned Devvit 0.13 CLI, upload --copy-paste only changes the login auth path: the upload command parses that flag and passes it to getAccessTokenAndLoginIfNeeded, while the first-time App Directory link still calls #initApp()/getCodeFromWizard() without that flag (checked upstream reddit/devvit packages/cli/src/commands/upload.ts). In the documented first-time flow users have already run devvit:login, so on a headless/SSH terminal this new fallback still opens the browser/local-redirect wizard and blocks instead of letting them paste the init code; either wire a real manual init flow or avoid advertising this script as the init fallback.
Useful? React with 👍 / 👎.
Summary
Test Plan
Summary by CodeRabbit
New Features
Documentation