Skip to content

feat(cli): configure Apps in Toss navigation chrome - #132

Merged
imjlk merged 3 commits into
mainfrom
codex/ait-transparent-navigation
Aug 11, 2026
Merged

imjlk merged 3 commits into
mainfrom
codex/ait-transparent-navigation

Conversation

@imjlk

@imjlk imjlk commented Aug 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add a validated navigationBar option to Apps in Toss target manifests
  • forward the target setting into generated Granite configuration
  • document transparent, dark game navigation defaults in the starter and add regression coverage

Validation

  • pnpm format
  • pnpm check
  • pnpm validate:starter-workflow
  • node tools/run-ttsx.mjs tools/target/web-artifact.test.ts
  • pnpm validate:targets
  • built TtokDoku AIT staging artifact and verified bundle.json contains transparentBackground true with dark navigation

Summary by CodeRabbit

  • New Features

    • Added configurable Apps-in-Toss navigation bars, including back, home, and title controls, transparency, and light/dark themes.
    • Navigation settings are validated and automatically applied during builds.
  • Documentation

    • Updated starter templates and guides with navigation-bar configuration examples.
  • Tests

    • Added validation coverage for supported and invalid navigation-bar settings.
    • Expanded starter workflow checks for navigation behavior.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@imjlk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 51d45af9-521d-4edf-bee7-4ff9f057c1ed

📥 Commits

Reviewing files that changed from the base of the PR and between 526e66b and c11f562.

📒 Files selected for processing (8)
  • apps/target-ait/apps-in-toss.config.ts
  • examples/phaser-starter/mpgd.targets.json
  • packages/cli/templates/phaser-game/README.md
  • packages/cli/templates/phaser-game/mpgd.targets.json
  • tools/target/platform-targets.ts
  • tools/target/schemas.ts
  • tools/target/web-artifact.test.ts
  • tools/validate-starter-workflow.ts
📝 Walkthrough

Walkthrough

The PR adds validated Apps in Toss navigation bar settings to target configuration. The build forwards these settings through an environment variable to the generated app config. Phaser starter files and workflow validation now use the transparent dark navigation bar configuration.

Changes

Apps in Toss navigation configuration

Layer / File(s) Summary
Navigation bar contract and validation
tools/target/schemas.ts, tools/target/platform-targets.ts, tools/target/web-artifact.test.ts
The target schema supports button visibility, transparency, and theme settings. Validation restricts values and rejects unknown options. Tests cover valid and invalid configurations.
Build-time navigation configuration
tools/target/build-target.ts, packages/cli/templates/phaser-game/apps/target-ait/apps-in-toss.config.ts
The build serializes navigationBar into MPGD_AIT_NAVIGATION_BAR. The generated app config parses the value and conditionally adds it to the wrapper configuration.
Starter configuration and workflow checks
packages/cli/templates/phaser-game/mpgd.targets.json, examples/phaser-starter/mpgd.targets.json, packages/cli/templates/phaser-game/README.md, tools/validate-starter-workflow.ts, .sampo/changesets/ait-target-navigation.md
Starter targets use a transparent dark navigation bar with navigation controls hidden. Documentation, workflow validation, and the package changeset describe the new configuration.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Developer
  participant mpgd.targets.json
  participant build-target.ts
  participant apps-in-toss.config.ts
  Developer->>mpgd.targets.json: configure navigationBar
  mpgd.targets.json->>build-target.ts: provide validated target settings
  build-target.ts->>apps-in-toss.config.ts: pass MPGD_AIT_NAVIGATION_BAR
  apps-in-toss.config.ts->>apps-in-toss.config.ts: parse and apply navigationBar
Loading

Possibly related PRs

  • imjlk/mpgd-kit#1: Shares Apps in Toss starter workflow and validation changes.
  • imjlk/mpgd-kit#7: Shares Phaser starter templates and mpgd.targets.json configuration.
  • imjlk/mpgd-kit#125: Shares target build configuration propagation and validation changes.

Poem

A bunny hops through config bright,
With hidden buttons, dark at night.
JSON travels, clean and true,
The starter knows just what to do.
Transparent chrome makes room to play!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: configuring Apps in Toss navigation chrome through the CLI.
Description check ✅ Passed The description includes the required Summary and Validation sections and gives specific implementation and verification details; only the optional Notes section is missing.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ait-transparent-navigation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@imjlk
imjlk marked this pull request as ready for review August 10, 2026 12:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 526e66b51a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@imjlk
imjlk force-pushed the codex/ait-transparent-navigation branch from 4a753ae to c11f562 Compare August 11, 2026 11:36

imjlk commented Aug 11, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@codex review

Re-review requested for rebased head c11f562bf4d6c39f252c55cf30a861920c2049f9. The navigation contract is now enforced across the root wrapper, generated starter, target schema, build forwarding, and artifact/starter tests. Local validation passed: pnpm check, test:target-artifacts, validate:starter-workflow, validate:targets, validate:target-config, validate:effective-config, smoke:effective-config, and git diff --check.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

@imjlk I will re-review pull request #132 at the rebased head. I will verify the navigation contract and the changed validation coverage.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: c11f562bf4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@imjlk
imjlk merged commit 2ef2ac3 into main Aug 11, 2026
6 checks passed
@imjlk
imjlk deleted the codex/ait-transparent-navigation branch October 27, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant