Skip to content

test: verify tutorial package consumption - #139

Merged
imjlk merged 2 commits into
mainfrom
codex/tutorial-package-validation
Aug 13, 2026
Merged

imjlk merged 2 commits into
mainfrom
codex/tutorial-package-validation

Conversation

@imjlk

@imjlk imjlk commented Aug 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add focused tutorial-core and tutorial-driver ttsc graph presets and include them in graph:preflight
  • add a hermetic packed-consumer smoke that installs @mpgd/tutorial from its pnpm tarball in an empty offline store
  • verify workspace dependency rewriting, all JavaScript subpath exports, the Driver integration, and the exported CSS
  • run the packed-consumer smoke from pack:packages:prepared so release packaging uses the same boundary check

This PR should merge before release PR #138 so the release branch can be regenerated from the validated main state.

Validation

  • pnpm graph:tutorial
  • pnpm graph:preflight
  • mise exec -- pnpm pack:packages:prepared
  • mise exec -- pnpm check
  • git diff --check

Changeset

No Sampo changeset: this is tooling and test coverage only and does not change a publishable package API, runtime, metadata, or integration contract.

Summary by CodeRabbit

  • Tests

    • Added an end-to-end smoke test validating package installation, dependency resolution, public imports, tutorial completion, progress persistence, and CSS exports.
  • Tooling

    • Added graph-based tutorial analysis requests covering core tutorial behavior and driver presentation flows.
    • Packaging now runs the tutorial package smoke test automatically.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ee79885-d381-4445-a7bb-3c2e3fa940a7

📥 Commits

Reviewing files that changed from the base of the PR and between 7e26c62 and 7968391.

📒 Files selected for processing (4)
  • package.json
  • packages/tutorial/test/package-import.mjs
  • tools/graph/requests/tutorial-core.json
  • tools/graph/requests/tutorial-driver.json

📝 Walkthrough

Walkthrough

The package workflow now runs an isolated tutorial package smoke test after packaging. The smoke test validates public imports, runtime behavior, dependency metadata, and CSS exports. New graph presets cover tutorial core and driver flows.

Changes

Tutorial package verification

Layer / File(s) Summary
Packaged tutorial consumer smoke test
package.json, packages/tutorial/test/package-import.mjs
The packaging workflow runs a new smoke test. The test installs local package archives offline, validates dependency metadata, exercises tutorial APIs, and checks the driver CSS export.

Tutorial graph requests

Layer / File(s) Summary
Tutorial graph preset wiring
package.json, tools/graph/requests/tutorial-core.json, tools/graph/requests/tutorial-driver.json
The graph:tutorial script runs core and driver presets. The presets describe tutorial lifecycle, persistence, presentation, accessibility, replay, and regression-test flows.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to 79683

This localized tooling and test-validation change has no actionable merge-blocking risk remaining after normal checks and review.

Possibly related PRs

  • imjlk/mpgd-kit#136: Introduced the tutorial package extended by this smoke test and graph configuration.

Poem

A rabbit packs the tutorial tight,
Tests each path by lantern light.
Graphs trace drivers, core flows sing,
CSS blooms from every spring.
Offline hops confirm the fare—
Clean packages everywhere.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: verifying consumption of the tutorial package.
Description check ✅ Passed The description explains the changes and validation commands, but it omits the template's Notes section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/tutorial-package-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 156715c672

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/graph/requests/tutorial-core.json Resolved
@imjlk

imjlk commented Aug 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 79683919fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@imjlk
imjlk merged commit 812c467 into main Aug 13, 2026
6 checks passed
@imjlk
imjlk deleted the codex/tutorial-package-validation branch August 13, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant