Repository navigation
feat: unify platform game flow contracts - #38
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds shared identity, launch, presentation, sharing, and notification contracts; target integration readiness snapshots; Phaser starter bootstrap fallbacks; bounded progress reconciliation; and durable, idempotent notification delivery. ChangesGame services
Platform flow adapters
Target readiness
Starter flow and documentation
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 820221677f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/target-ait/src/aitBridge.ts`:
- Around line 328-358: Update shareIntent to handle AbortError separately from
other failures: when getTossShareLink or share rejects with an AbortError,
return the ShareResult-compatible cancelled status; retain unavailable for
validation failures and all other errors, including the existing warning
behavior. Ensure the function’s return type includes cancelled and identify
AbortError robustly.
In `@packages/game-services/src/notification-delivery.ts`:
- Around line 513-519: Update normalizeTemplateData to enforce the 128-property
limit before calling Object.entries or otherwise materializing all values. After
assertRecord, incrementally count own enumerable properties and throw once the
count exceeds 128, then build the entries only after validation.
In `@packages/game-services/src/progress-link.ts`:
- Around line 468-470: In the metric-map handling logic around assertRecord,
avoid calling Object.entries before enforcing the entry limit; first count the
input’s own enumerable properties using a bounded approach, call
assertCollectionLimit with that count, then materialize Object.entries only
after validation and continue processing the entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 667f8e60-5f39-4c1f-bfc6-830aba7a744f
📒 Files selected for processing (47)
.sampo/changesets/game-services-platform-flow.md.sampo/changesets/platform-game-flow-adapters.md.sampo/changesets/starter-platform-flow.md.sampo/changesets/target-integration-readiness.mdREADME.mdadapters/ait/src/index.test.tsadapters/ait/src/index.tsadapters/browser/src/index.test.tsadapters/browser/src/index.tsadapters/capacitor/src/index.test.tsadapters/capacitor/src/index.tsadapters/devvit/src/index.test.tsadapters/devvit/src/index.tsapps/target-ait/src/aitBridge.tsapps/target-devvit/src/server/index.tsdocs/PLATFORM_GAME_FLOW.mdexamples/phaser-starter/agent/acceptance.mdexamples/phaser-starter/agent/brief.template.mdexamples/phaser-starter/agent/game.manifest.jsonexamples/phaser-starter/src/main.tsexamples/phaser-starter/src/runtime/starterContext.tsnative-plugins/capacitor-game-services/android/src/main/java/dev/mpgd/capacitor/CapacitorGameServicesPlugin.javanative-plugins/capacitor-game-services/ios/Sources/CapacitorGameServices/CapacitorGameServicesPlugin.swiftpackages/bridge/src/bridge-protocol.test.tspackages/bridge/src/fixtures.tspackages/bridge/src/index.tspackages/cli/templates/phaser-game/agent/acceptance.mdpackages/cli/templates/phaser-game/agent/game-manifest.jsonpackages/cli/templates/phaser-game/apps/target-devvit/src/server/index.tspackages/cli/templates/phaser-game/src/main.tspackages/cli/templates/phaser-game/src/runtime/gameContext.tspackages/game-services/package.jsonpackages/game-services/src/index.tspackages/game-services/src/notification-delivery.test.tspackages/game-services/src/notification-delivery.tspackages/game-services/src/progress-link.test.tspackages/game-services/src/progress-link.tspackages/game-services/src/server.tspackages/platform/src/index.tspackages/target-config/src/effective.tspackages/target-config/src/runtime.tspackages/target-config/targets.jsonpackages/target-config/test/target-config-smoke.tstools/smoke/effective-target-config.tstools/smoke/target-config-runtime.tstsconfig.graph.jsontsconfig.tools.json
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a63f57ecbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Trust boundaries
Per-commit Open Code Review
Validation
Deferred game-specific work
Summary by CodeRabbit