Repository navigation
chore: update ttsc toolchain - #55
Conversation
📝 WalkthroughWalkthroughThe pull request updates repository toolchain versions, pins ChangesToolchain pins and release metadata
Asynchronous graph inspection
TT SX generated-source cleanup
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant runTtsx
participant Filesystem
participant ttsx
runTtsx->>Filesystem: Clean generated source siblings
runTtsx->>ttsx: Run transformer
ttsx-->>runTtsx: Return status
runTtsx->>Filesystem: Clean generated source siblings
runTtsx-->>runTtsx: Resolve final status
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b4fde0d86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tools/run-ttsx.mjs (1)
66-66: 🚀 Performance & Scalability | 🔵 Trivial | ⚖️ Poor tradeoffFull recursive repo scan runs twice per invocation.
removeGeneratedSourceSiblings()walks the entireadapters/apps/backend/examples/native-plugins/packages/toolstree synchronously both before the spawn and again infinally. Sincerun-ttsx.mjsis invoked once per test file (e.g. the bridge package runs it three times), this is a repeated O(all-source-files) scan on the request path. Consider scoping the scan to the project/dir being run, or skipping the pre-run pass when the post-run pass suffices.Also applies to: 117-151
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/run-ttsx.mjs` at line 66, Reduce duplicate recursive scanning in run-ttsx.mjs by updating removeGeneratedSourceSiblings() usage around the pre-spawn and finally cleanup paths. Scope cleanup to the project or directory being run, or remove the redundant pre-run scan when the finally pass provides sufficient cleanup, while preserving generated-source removal behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tools/run-ttsx.mjs`:
- Line 66: Reduce duplicate recursive scanning in run-ttsx.mjs by updating
removeGeneratedSourceSiblings() usage around the pre-spawn and finally cleanup
paths. Scope cleanup to the project or directory being run, or remove the
redundant pre-run scan when the finally pass provides sufficient cleanup, while
preserving generated-source removal behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9be1650e-0dba-4792-bdce-63230803522e
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.sampo/changesets/update-ttsc-toolchain.mdadapters/ait/package.jsonadapters/browser/package.jsonadapters/capacitor/package.jsonadapters/devvit/package.jsonapps/game-services-worker/package.jsonapps/mobile-capacitor/package.jsonapps/target-ait/package.jsonapps/target-devvit/package.jsonapps/target-web-preview/package.jsonbackend/ad-reward-ledger/package.jsonbackend/entitlement-ledger/package.jsonbackend/game-services/package.jsonbackend/leaderboard-ledger/package.jsonbackend/purchase-verifier/package.jsonexamples/phaser-starter/package.jsonnative-plugins/capacitor-game-services/package.jsonpackage.jsonpackages/ad-placements/package.jsonpackages/analytics/package.jsonpackages/bridge/package.jsonpackages/catalog/package.jsonpackages/cli/package.jsonpackages/cli/templates/phaser-game/apps/target-cloudflare-pages/package.jsonpackages/cli/templates/phaser-game/apps/target-devvit/package.jsonpackages/cli/templates/phaser-game/package.jsonpackages/create-game/package.jsonpackages/game-anti-cheat/package.jsonpackages/game-core/package.jsonpackages/game-economy/package.jsonpackages/game-save/package.jsonpackages/game-services-contract/package.jsonpackages/game-services/package.jsonpackages/i18n/package.jsonpackages/leaderboard-contract/package.jsonpackages/monetization-contract/package.jsonpackages/phaser-assets/package.jsonpackages/platform/package.jsonpackages/release-manifest/package.jsonpackages/target-config/package.jsontools/graph/inspect-local-graph.mjstools/graph/local-graph-runtime.mjstools/graph/run-graph-presets.mjstools/run-ttsx.mjs
|
Review updates are in e17e4e3:
@coderabbitai review |
|
✏️ Learnings added
✅ Action performedReview finished.
|
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
ttscand the@ttsc/*toolchain from 0.16.9 to 0.18.4 across the workspace and generated starter manifestsminimumReleaseAgeExcludewith the pinned ttsc and typia releases@ttsc/graphapplication APIWhy
The workspace was pinned to older compiler tooling and release-candidate dependencies. The current graph API is asynchronous, so the local graph preflight also needed to await inspection results after the upgrade.
The updated ttsx dependency-build path can emit temporary JavaScript beside sources whose project has no
outDir. The shared runner removes those unintended source siblings before and after execution while preserving intentional Paraglide output and the original process failure signal.Impact
Generated Phaser starters, published package metadata, and repository development workflows now use the current stable compiler toolchain. Packages intentionally pinned to TypeScript 5.9.3 retain that version.
Validation
pnpm install --frozen-lockfilepnpm checkpnpm lintpnpm test:preparedpnpm graph:preflightpnpm validate:catalogpnpm validate:adspnpm validate:target-configpnpm validate:effective-configpnpm validate:targetspnpm smoke:effective-configpnpm smoke:adapter-effective-configpnpm build:websampo release --dry-runfrom a temporary main checkout; all 15 patch releases plannedNotes
pnpm build:aitreaches production readiness validation locally and stops becauseait.icon.externalUrlis not configured. The GitHub AIT staging job supplies its build inputs and passes the realait buildplus smoke path.